feat: report prerequisite relations in AllFlagState #19
Conversation
| @@ -295,7 +332,10 @@ public override FeatureFlagsState Read(ref Utf8JsonReader reader, Type typeToCon | |||
| for (var flagsObj = RequireObject(ref reader); flagsObj.Next(ref reader);) | |||
| { | |||
| var subKey = flagsObj.Name; | |||
| var flag = flags.ContainsKey(subKey) ? flags[subKey] : new FlagState(); | |||
There was a problem hiding this comment.
Slightly awkward: have to new the prerequisite list here in the deserializer, and also on line 375. I'd rather just have this in the constructor so it's never a question, but looks like structs in our language version can't define constructors.
Another option is to make a null list be a possibility. Logically that'd be fine, but.. I'd rather the consumers never need to question if it's null or not. I could be convinced otherwise.
| @@ -371,8 +372,7 @@ public FeatureFlagsState AllFlagsState(Context context, params FlagsStateOption[ | |||
|
|
|||
| var builder = new FeatureFlagsStateBuilder(options); | |||
There was a problem hiding this comment.
These weren't used at all in this function. They are used internal to the FeatureFlagsStateBuilder, presumably they didn't get cleaned up when that was introduced.
|
|
||
| var directPrerequisites = result.PrerequisiteEvals.Where( | ||
| e => e.FlagKey == flag.Key) | ||
| .Select(p => p.PrerequisiteFlag.Key).ToList(); |
There was a problem hiding this comment.
Converting to a list here, rather than leaving as an IEnumerable, because the intent is that order is preserved.
This PR updates
AllFlagsStateto track prerequisite evaluations.This didn't require modifying the Evaluator interface, as it already returns prerequisites as part of the
EvalResult.When the returned
FlagStateis marshaled to JSON, it will now contain the prerequisite info for each flag.