-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: report prerequisite relations in AllFlagState #19
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
using System; | ||
using System.Collections.Generic; | ||
using System.Linq; | ||
using System.Security.Cryptography; | ||
using LaunchDarkly.Logging; | ||
|
@@ -371,8 +372,7 @@ public FeatureFlagsState AllFlagsState(Context context, params FlagsStateOption[ | |
|
||
var builder = new FeatureFlagsStateBuilder(options); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These weren't used at all in this function. They are used internal to the |
||
var clientSideOnly = FlagsStateOption.HasOption(options, FlagsStateOption.ClientSideOnly); | ||
var withReasons = FlagsStateOption.HasOption(options, FlagsStateOption.WithReasons); | ||
var detailsOnlyIfTracked = FlagsStateOption.HasOption(options, FlagsStateOption.DetailsOnlyForTrackedFlags); | ||
|
||
KeyedItems<ItemDescriptor> flags; | ||
try | ||
{ | ||
|
@@ -397,6 +397,11 @@ public FeatureFlagsState AllFlagsState(Context context, params FlagsStateOption[ | |
{ | ||
EvaluatorTypes.EvalResult result = _evaluator.Evaluate(flag, context); | ||
bool inExperiment = EventFactory.IsExperiment(flag, result.Result.Reason); | ||
|
||
var directPrerequisites = result.PrerequisiteEvals.Where( | ||
e => e.FlagKey == flag.Key) | ||
.Select(p => p.PrerequisiteFlag.Key).ToList(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Converting to a list here, rather than leaving as an |
||
|
||
builder.AddFlag( | ||
flag.Key, | ||
result.Result.Value, | ||
|
@@ -405,16 +410,16 @@ public FeatureFlagsState AllFlagsState(Context context, params FlagsStateOption[ | |
flag.Version, | ||
flag.TrackEvents || inExperiment, | ||
inExperiment, | ||
flag.DebugEventsUntilDate | ||
); | ||
flag.DebugEventsUntilDate, | ||
directPrerequisites); | ||
} | ||
catch (Exception e) | ||
{ | ||
LogHelpers.LogException(_evalLog, | ||
string.Format("Exception caught for feature flag \"{0}\" when evaluating all flags", flag.Key), | ||
e); | ||
EvaluationReason reason = EvaluationReason.ErrorReason(EvaluationErrorKind.Exception); | ||
builder.AddFlag(flag.Key, new EvaluationDetail<LdValue>(LdValue.Null, null, reason)); | ||
builder.AddFlag(flag.Key, new EvaluationDetail<LdValue>(LdValue.Null, null, reason), new List<string>()); | ||
} | ||
} | ||
return builder.Build(); | ||
|
@@ -477,7 +482,7 @@ public FeatureFlagsState AllFlagsState(Context context, params FlagsStateOption[ | |
foreach (var prereqEvent in evalResult.PrerequisiteEvals) | ||
{ | ||
_eventProcessor.RecordEvaluationEvent(eventFactory.NewPrerequisiteEvaluationEvent( | ||
prereqEvent.PrerequisiteFlag, context, prereqEvent.Result, prereqEvent.PrerequisiteOfFlagKey)); | ||
prereqEvent.PrerequisiteFlag, context, prereqEvent.Result, prereqEvent.FlagKey)); | ||
} | ||
} | ||
var evalDetail = evalResult.Result; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slightly awkward: have to
new
the prerequisite list here in the deserializer, and also on line 375. I'd rather just have this in the constructor so it's never a question, but looks like structs in our language version can't define constructors.Another option is to make a null list be a possibility. Logically that'd be fine, but.. I'd rather the consumers never need to question if it's null or not. I could be convinced otherwise.