-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support enterprise hosted github instances #143
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for raising this @collinmurd!
I've left a couple of comments, one of them depending on us releasing an updated version this week
Co-authored-by: Fabian <feldbergf@gmail.com>
Thanks @monsagri! I'll keep an eye on your PR to upgrade |
Hey @collinmurd - We've just published the new version, would you be able to merge and give it a spin now? |
Hey @monsagri. I'm running into an issue that may or may not be separate from this change. The action is unable to create flag links in the app (with
I've confirmed this happens both before merging in the The first time this runs on a PR, it successfully creates the I'm doing some debugging, but this is my first time in Go, so it might be a slow process. If you have any ideas let me know! At this point I'm not sure whether this issue is due to the integration with GitHub Enterprise, or if it's something to do with our self-hosted Actions runners, or even something to do with the change I made. So if you guys would prefer, I could close this PR for now and create an issue instead. |
see #102
This adds support for GitHub Enterprise Server under a different hostname.
GITHUB_SERVER_URL
is a default environment variable that is set on the runner to the url of whatever github instance it's associated with.I only have my enterprise's environment to test with, this should be tested against github.com as well.