Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump go-github to current v68 #145

Merged
merged 4 commits into from
Jan 15, 2025
Merged

Conversation

monsagri
Copy link
Contributor

@monsagri monsagri commented Jan 9, 2025

As part of looking at https://launchdarkly.atlassian.net/browse/REL-4888 and the related customer created PR, I noticed that we haven't bumped the go-github version since August 2018 😅.

The main reason I'd like to update is that the customer PR wants to use a method to support Enterprise hosted instances which has actually been deprecated in more modern versions of the package.

It looks like there aren't any breaking changes for us to worry about, but there's definitely a lot happening here.

I've tested this locally with act and it works as expected

@monsagri monsagri requested a review from a team as a code owner January 9, 2025 15:46
Copy link
Contributor

@ldhenry ldhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@monsagri
Copy link
Contributor Author

LaunchDarkly flag references

🔍 1 flag added or modified

Name Key Aliases found Info
Start Trial free-trial free_trial

@monsagri monsagri force-pushed the ffeldberg/REL-4888/bump-go-github branch from 396ba6b to 60f0f2e Compare January 15, 2025 13:24
@BehnH BehnH merged commit 545911a into main Jan 15, 2025
4 of 6 checks passed
@BehnH BehnH deleted the ffeldberg/REL-4888/bump-go-github branch January 15, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants