diff --git a/.changeset/angry-pears-return.md b/.changeset/angry-pears-return.md index 350f4a7d1..637903452 100644 --- a/.changeset/angry-pears-return.md +++ b/.changeset/angry-pears-return.md @@ -1,6 +1,8 @@ --- "@launchpad-ui/icons": minor +"@launchpad-ui/avatar": patch "@launchpad-ui/chip": patch +"@launchpad-ui/filter": patch "@launchpad-ui/core": patch --- @@ -9,3 +11,4 @@ Align API with RAC components: - Remove outer `span` - Prop `subtle` -> `variant` - Prop `children` for custom icons + - Consolidate sizes diff --git a/packages/avatar/src/Avatar.tsx b/packages/avatar/src/Avatar.tsx index 7b2efd18c..e9c3552d3 100644 --- a/packages/avatar/src/Avatar.tsx +++ b/packages/avatar/src/Avatar.tsx @@ -80,8 +80,9 @@ const Avatar = ({ } return cloneElement(defaultIcon, { className: classes, + // @ts-expect-error pass through 'data-test-id': testId, - size, + ...(size !== 'tiny' && { size }), ...(rest as IconProps), }); } diff --git a/packages/filter/src/FilterButton.tsx b/packages/filter/src/FilterButton.tsx index b6aa07afc..1c8fa38d1 100644 --- a/packages/filter/src/FilterButton.tsx +++ b/packages/filter/src/FilterButton.tsx @@ -92,7 +92,7 @@ const FilterButton = forwardRef((props, ref) => { aria-label={ariaLabel} className={styles.clear} data-test-id="clear-filter-button" - icon={} + icon={} size="small" onClick={onClear} /> diff --git a/packages/icons/src/Icon.tsx b/packages/icons/src/Icon.tsx index c30ccb8ac..c40a4cf14 100644 --- a/packages/icons/src/Icon.tsx +++ b/packages/icons/src/Icon.tsx @@ -63,7 +63,8 @@ const Icon = ({ > {title && {title}} {description && {description}} - {children || } + {name && } + {children} ); }; diff --git a/packages/tag/stories/Tag.stories.tsx b/packages/tag/stories/Tag.stories.tsx index 177799b6b..68d852a04 100644 --- a/packages/tag/stories/Tag.stories.tsx +++ b/packages/tag/stories/Tag.stories.tsx @@ -206,7 +206,7 @@ export const WithCustomTagContent: Story = { {(item) => ( - {item.name} + {item.name} )}