feat(box): support className
#1432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 466ef6e The changes in this PR will be included in the next version bump. This PR includes changesets to release 24 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: +1.74 kB (+0.31%) Total Size: 554 kB
ℹ️ View Unchanged
|
zmdavis
approved these changes
Oct 7, 2024
packages/box/src/Box.tsx
Outdated
| const Component = asChild ? Slot : 'div'; | ||
| const { className, style, otherProps } = rainbowSprinkles(props); | ||
|
|
||
| return ( | ||
| <Component className={className} style={style} data-test-id={testId} {...otherProps}> | ||
| <Component className={cx(classes, className)} style={style} {...otherProps}> |
There was a problem hiding this comment.
Personally I find this a little confusing and would prefer to rename the sprinkles variable to make it more obvious what's happening, but that's minor and you can take or leave that suggestion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Support
className.