Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): add new icons in launchpad #1439

Merged
merged 13 commits into from
Oct 17, 2024

Conversation

tiffanylphan
Copy link
Contributor

@tiffanylphan tiffanylphan commented Oct 9, 2024

Summary

Add AI Config icons 🐌
https://www.figma.com/design/eSqxBJ2xm4wKVTVEBzTr5T/AI-Configs?node-id=87-8745&node-type=canvas&t=LU1KaBg6KplKqPhY-0

Screenshots (if appropriate):

Testing approaches

Copy link

changeset-bot bot commented Oct 9, 2024

🦋 Changeset detected

Latest commit: d65fec7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 23 packages
Name Type
@launchpad-ui/icons Patch
@launchpad-ui/alert Patch
@launchpad-ui/avatar Patch
@launchpad-ui/banner Patch
@launchpad-ui/button Patch
@launchpad-ui/chip Patch
@launchpad-ui/clipboard Patch
@launchpad-ui/collapsible Patch
@launchpad-ui/components Patch
@launchpad-ui/drawer Patch
@launchpad-ui/dropdown Patch
@launchpad-ui/filter Patch
@launchpad-ui/form Patch
@launchpad-ui/inline-edit Patch
@launchpad-ui/menu Patch
@launchpad-ui/modal Patch
@launchpad-ui/navigation Patch
@launchpad-ui/pagination Patch
@launchpad-ui/select Patch
@launchpad-ui/tag Patch
@launchpad-ui/core Patch
@launchpad-ui/split-button Patch
@launchpad-ui/card Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 9, 2024

Size Change: 0 B

Total Size: 549 kB

ℹ️ View Unchanged
Filename Size
apps/vscode/dist/client.js 111 kB
apps/vscode/dist/server.js 244 kB
packages/alert/dist/index.es.js 1.3 kB
packages/alert/dist/index.js 1.37 kB
packages/alert/dist/style.css 1.36 kB
packages/avatar/dist/index.es.js 1.16 kB
packages/avatar/dist/index.js 1.23 kB
packages/avatar/dist/style.css 406 B
packages/banner/dist/index.es.js 624 B
packages/banner/dist/index.js 695 B
packages/banner/dist/style.css 474 B
packages/box/dist/index.es.js 6.83 kB
packages/box/dist/index.js 6.95 kB
packages/box/dist/style.css 2.65 kB
packages/button/dist/index.es.js 1.81 kB
packages/button/dist/index.js 1.89 kB
packages/button/dist/style.css 3.17 kB
packages/card/dist/index.es.js 688 B
packages/card/dist/index.js 754 B
packages/card/dist/style.css 666 B
packages/chip/dist/index.es.js 674 B
packages/chip/dist/index.js 745 B
packages/chip/dist/style.css 535 B
packages/clipboard/dist/index.es.js 1.49 kB
packages/clipboard/dist/index.js 1.57 kB
packages/clipboard/dist/style.css 802 B
packages/collapsible/dist/index.es.js 856 B
packages/collapsible/dist/index.js 926 B
packages/collapsible/dist/style.css 81 B
packages/columns/dist/index.es.js 579 B
packages/columns/dist/index.js 651 B
packages/columns/dist/style.css 281 B
packages/components/dist/index.es.js 11.3 kB
packages/components/dist/index.js 11.2 kB
packages/components/dist/style.css 6.72 kB
packages/core/dist/index.es.js 1.06 kB
packages/core/dist/index.js 1.41 kB
packages/counter/dist/index.es.js 330 B
packages/counter/dist/index.js 397 B
packages/counter/dist/style.css 248 B
packages/drawer/dist/index.es.js 1.7 kB
packages/drawer/dist/index.js 2.25 kB
packages/drawer/dist/style.css 490 B
packages/dropdown/dist/index.es.js 1.14 kB
packages/dropdown/dist/index.js 1.2 kB
packages/filter/dist/index.es.js 2.28 kB
packages/filter/dist/index.js 2.35 kB
packages/filter/dist/style.css 907 B
packages/focus-trap/dist/index.es.js 267 B
packages/focus-trap/dist/index.js 333 B
packages/form/dist/index.es.js 4.13 kB
packages/form/dist/index.js 4.24 kB
packages/form/dist/style.css 2.23 kB
packages/icons/dist/index.es.js 947 B
packages/icons/dist/index.js 1.02 kB
packages/icons/dist/style.css 221 B
packages/inline-edit/dist/index.es.js 1.57 kB
packages/inline-edit/dist/index.js 1.65 kB
packages/inline-edit/dist/style.css 329 B
packages/inline/dist/index.es.js 572 B
packages/inline/dist/index.js 643 B
packages/inline/dist/style.css 243 B
packages/markdown/dist/index.es.js 963 B
packages/markdown/dist/index.js 1.04 kB
packages/markdown/dist/style.css 217 B
packages/menu/dist/index.es.js 3.8 kB
packages/menu/dist/index.js 3.88 kB
packages/menu/dist/style.css 860 B
packages/modal/dist/index.es.js 2.97 kB
packages/modal/dist/index.js 3.54 kB
packages/modal/dist/style.css 892 B
packages/navigation/dist/index.es.js 2.73 kB
packages/navigation/dist/index.js 2.81 kB
packages/navigation/dist/style.css 866 B
packages/overlay/dist/index.es.js 1.03 kB
packages/overlay/dist/index.js 1.09 kB
packages/pagination/dist/index.es.js 1.15 kB
packages/pagination/dist/index.js 1.23 kB
packages/pagination/dist/style.css 300 B
packages/popover/dist/index.es.js 3.06 kB
packages/popover/dist/index.js 3.56 kB
packages/popover/dist/style.css 518 B
packages/portal/dist/index.es.js 398 B
packages/portal/dist/index.js 457 B
packages/progress-bubbles/dist/index.es.js 1.74 kB
packages/progress-bubbles/dist/index.js 1.81 kB
packages/progress-bubbles/dist/style.css 811 B
packages/progress/dist/index.es.js 1.07 kB
packages/progress/dist/index.js 1.14 kB
packages/progress/dist/style.css 267 B
packages/select/dist/index.es.js 5.86 kB
packages/select/dist/index.js 5.94 kB
packages/select/dist/style.css 1.12 kB
packages/split-button/dist/index.es.js 940 B
packages/split-button/dist/index.js 1.01 kB
packages/split-button/dist/style.css 521 B
packages/stack/dist/index.es.js 464 B
packages/stack/dist/index.js 535 B
packages/stack/dist/style.css 181 B
packages/tab-list/dist/index.es.js 728 B
packages/tab-list/dist/index.js 801 B
packages/tab-list/dist/style.css 410 B
packages/table/dist/index.es.js 931 B
packages/table/dist/index.js 1.01 kB
packages/table/dist/style.css 689 B
packages/tag/dist/index.es.js 2.86 kB
packages/tag/dist/index.js 2.94 kB
packages/tag/dist/style.css 740 B
packages/tokens/dist/fonts.css 183 B
packages/tokens/dist/index.css 2.37 kB
packages/tokens/dist/index.es.js 2.7 kB
packages/tokens/dist/index.js 2.7 kB
packages/tokens/dist/media-queries.css 114 B
packages/tokens/dist/themes.css 1.11 kB
packages/tooltip/dist/index.es.js 506 B
packages/tooltip/dist/index.js 581 B
packages/tooltip/dist/style.css 326 B
packages/vars/dist/index.es.js 2.37 kB
packages/vars/dist/index.js 2.44 kB

compressed-size-action

@tiffanylphan tiffanylphan changed the title Rel 1714 add new icons in launchpad feat(icons): add new icons in launchpad Oct 9, 2024
Copy link
Contributor

@Niznikr Niznikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to get rid of any fills.

Copy link
Contributor

@Niznikr Niznikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still seeing fills defined. Also the sprite file has more added than what the types diff shows.

Copy link
Contributor

@Niznikr Niznikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! Not seeing markdown off render

Screenshot 2024-10-16 at 1 42 42 PM

@Niznikr Niznikr merged commit 3764368 into main Oct 17, 2024
17 checks passed
@Niznikr Niznikr deleted the REL-1714-add-new-icons-in-launchpad branch October 17, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants