Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inline-edit): forward ref and spread additional props #946

Merged
merged 4 commits into from
Aug 2, 2023

Conversation

Niznikr
Copy link
Contributor

@Niznikr Niznikr commented Aug 2, 2023

Summary

Forward the ref of the edit input and spread additional props onto the container.

@Niznikr Niznikr requested review from a team, apucacao, stinachen and vroske-ld August 2, 2023 13:55
@changeset-bot
Copy link

changeset-bot bot commented Aug 2, 2023

🦋 Changeset detected

Latest commit: 70b4597

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@launchpad-ui/inline-edit Patch
@launchpad-ui/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

Size Change: +171 B (0%)

Total Size: 161 kB

Filename Size Change
packages/inline-edit/dist/index.es.js 1.48 kB +85 B (+6%) 🔍
packages/inline-edit/dist/index.js 1.57 kB +86 B (+6%) 🔍
ℹ️ View Unchanged
Filename Size
packages/alert/dist/index.es.js 1.02 kB
packages/alert/dist/index.js 1.09 kB
packages/alert/dist/style.css 1.03 kB
packages/avatar/dist/index.es.js 1.16 kB
packages/avatar/dist/index.js 1.23 kB
packages/avatar/dist/style.css 466 B
packages/banner/dist/index.es.js 641 B
packages/banner/dist/index.js 711 B
packages/banner/dist/style.css 545 B
packages/button/dist/index.es.js 1.62 kB
packages/button/dist/index.js 1.7 kB
packages/button/dist/style.css 3.08 kB
packages/chip/dist/index.es.js 676 B
packages/chip/dist/index.js 746 B
packages/chip/dist/style.css 895 B
packages/clipboard/dist/index.es.js 1.51 kB
packages/clipboard/dist/index.js 1.59 kB
packages/clipboard/dist/style.css 829 B
packages/collapsible/dist/index.es.js 853 B
packages/collapsible/dist/index.js 919 B
packages/collapsible/dist/style.css 94 B
packages/columns/dist/index.es.js 619 B
packages/columns/dist/index.js 692 B
packages/columns/dist/style.css 354 B
packages/core/dist/index.es.js 1.1 kB
packages/core/dist/index.js 1.47 kB
packages/counter/dist/index.es.js 333 B
packages/counter/dist/index.js 396 B
packages/counter/dist/style.css 256 B
packages/drawer/dist/index.es.js 1.73 kB
packages/drawer/dist/index.js 2.29 kB
packages/drawer/dist/style.css 570 B
packages/dropdown/dist/index.es.js 1.14 kB
packages/dropdown/dist/index.js 1.2 kB
packages/filter/dist/index.es.js 2.3 kB
packages/filter/dist/index.js 2.37 kB
packages/filter/dist/style.css 1 kB
packages/focus-trap/dist/index.es.js 268 B
packages/focus-trap/dist/index.js 331 B
packages/form/dist/index.es.js 3.99 kB
packages/form/dist/index.js 4.1 kB
packages/form/dist/style.css 2.68 kB
packages/icons/dist/index.es.js 1.28 kB
packages/icons/dist/index.js 1.35 kB
packages/icons/dist/style.css 615 B
packages/inline-edit/dist/style.css 338 B
packages/inline/dist/index.es.js 565 B
packages/inline/dist/index.js 637 B
packages/inline/dist/style.css 299 B
packages/markdown/dist/index.es.js 960 B
packages/markdown/dist/index.js 1.03 kB
packages/markdown/dist/style.css 234 B
packages/menu/dist/index.es.js 3.55 kB
packages/menu/dist/index.js 3.63 kB
packages/menu/dist/style.css 1.22 kB
packages/modal/dist/index.es.js 3.02 kB
packages/modal/dist/index.js 3.58 kB
packages/modal/dist/style.css 1.03 kB
packages/navigation/dist/index.es.js 2.79 kB
packages/navigation/dist/index.js 2.85 kB
packages/navigation/dist/style.css 1.25 kB
packages/overlay/dist/index.es.js 1 kB
packages/overlay/dist/index.js 1.06 kB
packages/pagination/dist/index.es.js 1.18 kB
packages/pagination/dist/index.js 1.26 kB
packages/pagination/dist/style.css 356 B
packages/popover/dist/index.es.js 3.07 kB
packages/popover/dist/index.js 3.57 kB
packages/popover/dist/style.css 629 B
packages/portal/dist/index.es.js 390 B
packages/portal/dist/index.js 449 B
packages/progress-bubbles/dist/index.es.js 1.76 kB
packages/progress-bubbles/dist/index.js 1.83 kB
packages/progress-bubbles/dist/style.css 961 B
packages/progress/dist/index.es.js 1.02 kB
packages/progress/dist/index.js 1.09 kB
packages/progress/dist/style.css 278 B
packages/select/dist/index.es.js 5.91 kB
packages/select/dist/index.js 5.99 kB
packages/select/dist/style.css 1.34 kB
packages/slider/dist/index.es.js 579 B
packages/slider/dist/index.js 644 B
packages/slider/dist/style.css 672 B
packages/snackbar/dist/index.es.js 1.17 kB
packages/snackbar/dist/index.js 1.73 kB
packages/snackbar/dist/style.css 580 B
packages/split-button/dist/index.es.js 883 B
packages/split-button/dist/index.js 954 B
packages/split-button/dist/style.css 495 B
packages/stack/dist/index.es.js 494 B
packages/stack/dist/index.js 565 B
packages/stack/dist/style.css 226 B
packages/tab-list/dist/index.es.js 737 B
packages/tab-list/dist/index.js 809 B
packages/tab-list/dist/style.css 455 B
packages/table/dist/index.es.js 1.02 kB
packages/table/dist/index.js 1.1 kB
packages/table/dist/style.css 905 B
packages/tag/dist/index.es.js 2.85 kB
packages/tag/dist/index.js 2.92 kB
packages/tag/dist/style.css 945 B
packages/toast/dist/index.es.js 979 B
packages/toast/dist/index.js 1.53 kB
packages/toast/dist/style.css 544 B
packages/toggle/dist/index.es.js 764 B
packages/toggle/dist/index.js 844 B
packages/toggle/dist/style.css 1.52 kB
packages/tokens/dist/index.css 1.48 kB
packages/tokens/dist/index.es.js 1.93 kB
packages/tokens/dist/index.js 6.96 kB
packages/tokens/dist/media-queries.css 112 B
packages/tokens/dist/themes.css 1.11 kB
packages/tooltip/dist/index.es.js 514 B
packages/tooltip/dist/index.js 588 B
packages/tooltip/dist/style.css 366 B
packages/vars/dist/index.es.js 1.51 kB
packages/vars/dist/index.js 1.58 kB

compressed-size-action

@Niznikr Niznikr requested a review from pheggeseth August 2, 2023 14:31

return isEditing ? (
<div
{...rest}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume these props will always map to valid DOM attributes, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah the ones coming from ComponentProps<'div'>.

@Niznikr Niznikr merged commit f6ea128 into main Aug 2, 2023
10 checks passed
@Niznikr Niznikr deleted the feat/inline-edit-ref branch August 2, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants