-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(inline-edit): forward ref and spread additional props #946
Conversation
🦋 Changeset detectedLatest commit: 70b4597 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Change: +171 B (0%) Total Size: 161 kB
ℹ️ View Unchanged
|
|
||
return isEditing ? ( | ||
<div | ||
{...rest} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume these props will always map to valid DOM attributes, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah the ones coming from ComponentProps<'div'>
.
Summary
Forward the ref of the edit input and spread additional props onto the container.