Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: annotate pure functions #947

Merged
merged 3 commits into from
Aug 2, 2023
Merged

fix: annotate pure functions #947

merged 3 commits into from
Aug 2, 2023

Conversation

Niznikr
Copy link
Contributor

@Niznikr Niznikr commented Aug 2, 2023

Summary

Vite does not add pure annotations for some top-level functions due to esbuild decisions. We can use a rollup plugin to achieve this and improve tree shaking.

Testing approaches

Built packages have /* @__PURE__ */ annotation next to forwardRef, cloneElement, etc.

@changeset-bot
Copy link

changeset-bot bot commented Aug 2, 2023

🦋 Changeset detected

Latest commit: 55b7d9a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 29 packages
Name Type
@launchpad-ui/avatar Patch
@launchpad-ui/button Patch
@launchpad-ui/chip Patch
@launchpad-ui/clipboard Patch
@launchpad-ui/dropdown Patch
@launchpad-ui/filter Patch
@launchpad-ui/focus-trap Patch
@launchpad-ui/form Patch
@launchpad-ui/icons Patch
@launchpad-ui/inline-edit Patch
@launchpad-ui/menu Patch
@launchpad-ui/modal Patch
@launchpad-ui/navigation Patch
@launchpad-ui/popover Patch
@launchpad-ui/portal Patch
@launchpad-ui/snackbar Patch
@launchpad-ui/split-button Patch
@launchpad-ui/tooltip Patch
@launchpad-ui/core Patch
@launchpad-ui/alert Patch
@launchpad-ui/banner Patch
@launchpad-ui/collapsible Patch
@launchpad-ui/drawer Patch
@launchpad-ui/pagination Patch
@launchpad-ui/select Patch
@launchpad-ui/tag Patch
@launchpad-ui/toast Patch
@launchpad-ui/progress-bubbles Patch
@launchpad-ui/overlay Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

Size Change: +145 B (0%)

Total Size: 161 kB

Filename Size Change
packages/avatar/dist/index.js 1.23 kB +1 B (0%)
packages/button/dist/index.es.js 1.63 kB +8 B (0%)
packages/button/dist/index.js 1.71 kB +9 B (+1%)
packages/chip/dist/index.es.js 679 B +3 B (0%)
packages/chip/dist/index.js 749 B +3 B (0%)
packages/clipboard/dist/index.es.js 1.51 kB +3 B (0%)
packages/clipboard/dist/index.js 1.6 kB +5 B (0%)
packages/dropdown/dist/index.es.js 1.15 kB +7 B (+1%)
packages/dropdown/dist/index.js 1.21 kB +2 B (0%)
packages/filter/dist/index.es.js 2.3 kB +3 B (0%)
packages/focus-trap/dist/index.es.js 270 B +2 B (+1%)
packages/focus-trap/dist/index.js 333 B +2 B (+1%)
packages/form/dist/index.es.js 4.01 kB +13 B (0%)
packages/form/dist/index.js 4.11 kB +9 B (0%)
packages/icons/dist/index.es.js 1.28 kB +5 B (0%)
packages/icons/dist/index.js 1.35 kB +3 B (0%)
packages/inline-edit/dist/index.js 1.49 kB +1 B (0%)
packages/menu/dist/index.es.js 3.55 kB +7 B (0%)
packages/menu/dist/index.js 3.64 kB +8 B (0%)
packages/modal/dist/index.es.js 3.03 kB +5 B (0%)
packages/modal/dist/index.js 3.58 kB +5 B (0%)
packages/navigation/dist/index.es.js 2.79 kB +4 B (0%)
packages/navigation/dist/index.js 2.86 kB +6 B (0%)
packages/popover/dist/index.es.js 3.07 kB +4 B (0%)
packages/popover/dist/index.js 3.58 kB +2 B (0%)
packages/portal/dist/index.es.js 393 B +3 B (+1%)
packages/portal/dist/index.js 453 B +4 B (+1%)
packages/snackbar/dist/index.es.js 1.18 kB +3 B (0%)
packages/snackbar/dist/index.js 1.73 kB +2 B (0%)
packages/split-button/dist/index.es.js 887 B +4 B (0%)
packages/split-button/dist/index.js 959 B +5 B (+1%)
packages/tokens/dist/index.css 1.48 kB -1 B (0%)
packages/tokens/dist/themes.css 1.11 kB -1 B (0%)
packages/tooltip/dist/index.es.js 517 B +3 B (+1%)
packages/tooltip/dist/index.js 591 B +3 B (+1%)
ℹ️ View Unchanged
Filename Size
packages/alert/dist/index.es.js 1.02 kB
packages/alert/dist/index.js 1.09 kB
packages/alert/dist/style.css 1.03 kB
packages/avatar/dist/index.es.js 1.16 kB
packages/avatar/dist/style.css 466 B
packages/banner/dist/index.es.js 641 B
packages/banner/dist/index.js 711 B
packages/banner/dist/style.css 545 B
packages/button/dist/style.css 3.08 kB
packages/chip/dist/style.css 895 B
packages/clipboard/dist/style.css 829 B
packages/collapsible/dist/index.es.js 853 B
packages/collapsible/dist/index.js 919 B
packages/collapsible/dist/style.css 94 B
packages/columns/dist/index.es.js 619 B
packages/columns/dist/index.js 692 B
packages/columns/dist/style.css 354 B
packages/core/dist/index.es.js 1.1 kB
packages/core/dist/index.js 1.47 kB
packages/counter/dist/index.es.js 333 B
packages/counter/dist/index.js 396 B
packages/counter/dist/style.css 256 B
packages/drawer/dist/index.es.js 1.73 kB
packages/drawer/dist/index.js 2.29 kB
packages/drawer/dist/style.css 570 B
packages/filter/dist/index.js 2.37 kB
packages/filter/dist/style.css 1 kB
packages/form/dist/style.css 2.68 kB
packages/icons/dist/style.css 615 B
packages/inline-edit/dist/index.es.js 1.39 kB
packages/inline-edit/dist/style.css 338 B
packages/inline/dist/index.es.js 565 B
packages/inline/dist/index.js 637 B
packages/inline/dist/style.css 299 B
packages/markdown/dist/index.es.js 960 B
packages/markdown/dist/index.js 1.03 kB
packages/markdown/dist/style.css 234 B
packages/menu/dist/style.css 1.22 kB
packages/modal/dist/style.css 1.03 kB
packages/navigation/dist/style.css 1.25 kB
packages/overlay/dist/index.es.js 1 kB
packages/overlay/dist/index.js 1.06 kB
packages/pagination/dist/index.es.js 1.18 kB
packages/pagination/dist/index.js 1.26 kB
packages/pagination/dist/style.css 356 B
packages/popover/dist/style.css 629 B
packages/progress-bubbles/dist/index.es.js 1.76 kB
packages/progress-bubbles/dist/index.js 1.83 kB
packages/progress-bubbles/dist/style.css 961 B
packages/progress/dist/index.es.js 1.02 kB
packages/progress/dist/index.js 1.09 kB
packages/progress/dist/style.css 278 B
packages/select/dist/index.es.js 5.91 kB
packages/select/dist/index.js 5.99 kB
packages/select/dist/style.css 1.34 kB
packages/slider/dist/index.es.js 579 B
packages/slider/dist/index.js 644 B
packages/slider/dist/style.css 672 B
packages/snackbar/dist/style.css 580 B
packages/split-button/dist/style.css 495 B
packages/stack/dist/index.es.js 494 B
packages/stack/dist/index.js 565 B
packages/stack/dist/style.css 226 B
packages/tab-list/dist/index.es.js 737 B
packages/tab-list/dist/index.js 809 B
packages/tab-list/dist/style.css 455 B
packages/table/dist/index.es.js 1.02 kB
packages/table/dist/index.js 1.1 kB
packages/table/dist/style.css 905 B
packages/tag/dist/index.es.js 2.85 kB
packages/tag/dist/index.js 2.92 kB
packages/tag/dist/style.css 945 B
packages/toast/dist/index.es.js 979 B
packages/toast/dist/index.js 1.53 kB
packages/toast/dist/style.css 544 B
packages/toggle/dist/index.es.js 764 B
packages/toggle/dist/index.js 844 B
packages/toggle/dist/style.css 1.52 kB
packages/tokens/dist/index.es.js 1.93 kB
packages/tokens/dist/index.js 6.96 kB
packages/tokens/dist/media-queries.css 112 B
packages/tooltip/dist/style.css 366 B
packages/vars/dist/index.es.js 1.51 kB
packages/vars/dist/index.js 1.58 kB

compressed-size-action

Copy link
Contributor

@goyanespaula goyanespaula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@Niznikr Niznikr merged commit 29e2b26 into main Aug 2, 2023
10 checks passed
@Niznikr Niznikr deleted the fix/pure-annotation branch August 2, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants