feat: Add initial implementation of provider #1
Conversation
|
This pull request has been linked to Shortcut Story #249042: Initial implementation of provider. |
lib/ldclient-openfeature/provider.rb
Outdated
| return mismatched_type_details(default_value) | ||
| elsif flag_type == :string && !evaluation_detail.value.is_a?(String) | ||
| return mismatched_type_details(default_value) | ||
| elsif flag_type == :integer && !evaluation_detail.value.is_a?(Integer) |
There was a problem hiding this comment.
I think we would want coercion on either a float or an int to either type. To prevent unexpected behavior when some values happen to be integers and then aren't.
There was a problem hiding this comment.
I'm not sure I follow. Are you suggesting that the return value from this method call should be cast to an int, or that I should allow both floats and ints, but cast that value?
There was a problem hiding this comment.
So, I am not familiar with ruby enough to know for sure how it works.
But generally speaking LD supports only numbers (which are represented as JSON, which is a double). Not doubles or ints. So if you evaluate a number as an int it should be cast to an int, and if you evaluate it as a double, then it should be the number.
🤖 I have created a release *beep* *boop* --- ## 0.1.0 (2024-08-05) ### Features * Add initial implementation of provider ([#1](#1)) ([7550e14](7550e14)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
BEGIN_COMMIT_OVERRIDE
feat: Add initial implementation of provider (#1)
Release-As: 0.1.0
END_COMMIT_OVERRIDE