feat: Add support for big segments #213
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keelerm84
force-pushed
the
mk/sdk-1032/big-segment-support
branch
6 times, most recently
from
a7a2cbe to
62b63ba
Compare
keelerm84
force-pushed
the
mk/sdk-1032/big-segment-support
branch
from
62b63ba to
46af7c5
Compare
keelerm84
force-pushed
the
mk/sdk-1032/big-segment-support
branch
from
38aa1b6 to
7acecd7
Compare
keelerm84
force-pushed
the
mk/sdk-1032/big-segment-support
branch
2 times, most recently
from
0293108 to
c9a3649
Compare
keelerm84
force-pushed
the
mk/sdk-1032/big-segment-support
branch
from
c9a3649 to
fd289c7
Compare
| public function getContextMembership(string $contextKey): ?Impl\BigSegments\MembershipResult | ||
| { | ||
| if ($this->store === null) { | ||
| return null; |
There was a problem hiding this comment.
It is a little unclear in which cases null will be returned vs which cases a result with null membership and store error will come back.
| */ | ||
| class BigSegmentsConfig | ||
| { | ||
| const DEFAULT_STATUS_POLL_INTERVAL = 5; |
There was a problem hiding this comment.
What unit is this? Feels like it is minutes, but I guess could be seconds.
$nextPollingTime = ($this->lastStatusPollTime?->getTimestamp() ?? 0) + $this->config->statusPollInterval;
| * will be called only when the SDK needs the latest state, so it should | ||
| * not be cached. | ||
| */ | ||
| public function getMetadata(): Types\BigSegmentsStoreMetadata; |
There was a problem hiding this comment.
For failure cases, getMembership returns a nullable, but this does not. Should those be consistent?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.