chore: fix secret passing in release workflows (#189)

Fixes workflow syntax of the release workflow.
launchdarkly · Feb 21, 2024 · be3e5ec · be3e5ec
1 parent b244281
commit be3e5ec
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 8 deletions.
diff --git a/.github/workflows/manual-release.yml b/.github/workflows/manual-release.yml
@@ -11,5 +11,4 @@ jobs:
   manual-release:
     uses: ./.github/workflows/release.yml
     with:
-      token: ${{ secrets.GITHUB_TOKEN }}
       tag: ${{ inputs.tag }}
diff --git a/.github/workflows/release-please.yml b/.github/workflows/release-please.yml
@@ -20,11 +20,8 @@ jobs:
           target-branch: v2
 
   release-sdk-test-harness:
-    permissions:
-      contents: write
     needs: release-please
     if: needs.release-please.outputs.release_created == 'true'
     uses: ./.github/workflows/release.yml
     with:
-      token: ${{ secrets.GITHUB_TOKEN }}
       tag: ${{ needs.release-please.outputs.tag_name }}
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -1,11 +1,9 @@
 on:
   workflow_call:
     inputs:
-      token:
-        required: true
-        type: string
       tag:
         required: true
+        description: 'The tag to upload release artifacts to.'
         type: string
 
 jobs:
@@ -15,10 +13,12 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v4
+      with:
+        fetch-depth: 0 # Needed for goreleaser to inspect tags.
     - uses: ./.github/actions/ci
       with:
         run_linter: 'false'
     - uses: ./.github/actions/publish
       with:
-        token: ${{ github.event.inputs.token }}
+        token: ${{ secrets.GITHUB_TOKEN }}
         tag: ${{ github.event.inputs.tag }}