fix(deps): build with Go 1.22 #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwaldren-ld
commented
Feb 21, 2024
| @@ -1,3 +1,5 @@ | |||
| name: Publish Release | |||
|
|
|||
There was a problem hiding this comment.
Sneaking this in; without it it shows the full workflow file name in the UI.
cwaldren-ld
commented
Feb 21, 2024
| @@ -5,8 +5,6 @@ run: | |||
| linters: | |||
| enable: | |||
| - bodyclose | |||
There was a problem hiding this comment.
deadcode,structcheck,varcheck are unmaintained/deprecated
There was a problem hiding this comment.
Removed depguard because I don't know why we were using it (and it wasn't configured.) The purpose is to restrict the module from importing certain packages; we don't have such a policy for this tool as far as I know.
cwaldren-ld
commented
Feb 21, 2024
| @@ -24,18 +22,14 @@ linters: | |||
| - megacheck | |||
| - misspell | |||
| - nakedret | |||
There was a problem hiding this comment.
nolintlint works fine with go1.22
cwaldren-ld
commented
Feb 21, 2024
| @@ -100,11 +100,11 @@ func (f *ContextFactory) SetKeyDisambiguatorValueSameAs(f1 *ContextFactory) { | |||
| // Each will have an appropriate Description, so the logic for running a test against each one can look | |||
cwaldren-ld
requested review from
a team,
tanderson-ld,
louis-launchdarkly and
kinyoklion
kinyoklion
reviewed
Feb 21, 2024
| @@ -227,7 +227,7 @@ func (c CommonEventTests) EventContexts(t *ldtest.T) { | |||
|
|
|||
| if user := representContextAsOldUser(t, context); user != nil { | |||
| t.Run("with old user", func(t *ldtest.T) { | |||
| _ = basicEvaluateFlagWithOldUser(t, client, flagKey, user, defaultValue) | |||
There was a problem hiding this comment.
Not related to this change, but this is some non-intuitive data flow.
kinyoklion
approved these changes
Feb 21, 2024
cwaldren-ld
changed the title
cwaldren-ld
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds sdk-test-harness with Go 1.22, up from Go 1.18. With this change, we can pull in a new
golanglintciversion.This surfaced a bunch of new lints, which I've fixed.