feat: test hook error handling #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwaldren-ld
force-pushed
the
cw/hook-errors
branch
from
e2751aa to
8b04a3d
Compare
cwaldren-ld
force-pushed
the
cw/hook-errors
branch
from
8b04a3d to
038084f
Compare
cwaldren-ld
force-pushed
the
cw/hook-errors
branch
from
1bc25e3 to
2577036
Compare
cwaldren-ld
commented
Apr 2, 2024
| @@ -78,3 +84,28 @@ func (h *Hooks) ExpectCall(t *ldtest.T, hookName string, | |||
| } | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
This is a somewhat janky expectation method. But, we couldn't quite think of what we'd want to see if this was more generic.
So, I think we should feel free to refactor or replace this when the time comes. Or now, if there's a better idea.
kinyoklion
reviewed
Apr 2, 2024
kinyoklion
reviewed
Apr 2, 2024
|
I approve, but since we paired on this and others have started reviewing, I will not officially approve to give other reviewers an opportunity before it merges. |
tanderson-ld
reviewed
Apr 2, 2024
tanderson-ld
reviewed
Apr 2, 2024
kinyoklion
reviewed
Apr 2, 2024
kinyoklion
approved these changes
Apr 2, 2024
kinyoklion
pushed a commit
that referenced
this pull request
Apr 8, 2024
🤖 I have created a release *beep* *boop* --- ## [2.10.0](v2.9.0...v2.10.0) (2024-04-03) ### Features * test hook error handling ([#202](#202)) ([256ae92](256ae92)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a test that the SDK can successfully recover from a hook stage returning an error or throwing an exception. It runs under existing capability
evaluation-hooks.This introduces a new
errorsobject on the Hooks service definition which SDKs must inspect. It contains an error message that should be thrown/returned from a specific stage.I've only written one test here, which is that:
beforeEvaluationstage, ensure theafterEvaluationstage still runs.Existing SDKs are expected to fail this test until implemented. I thought about having it as a new capability, but it is part of the base spec and the reminder (seeing the test fail) should be helpful.