feat: Test that client-side SDKs send correct version in events. #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwaldren-ld
approved these changes
Oct 7, 2024
kinyoklion
pushed a commit
that referenced
this pull request
Oct 9, 2024
🤖 I have created a release *beep* *boop* --- ## [2.23.0](v2.22.0...v2.23.0) (2024-10-08) ### Features * Test that client-side SDKs send correct version in events. ([#240](#240)) ([0b4df84](0b4df84)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't the ideal modification, but it changes things to ensure that by default client-side SDKs are sent a flagVersion in addition to a version and that they are not the same by default.
Events should use the flagVersion when available.