feat: Add client-prereq-events capability
#242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keelerm84
commented
Oct 9, 2024
| WithClientSideInitialContext(contextA), | ||
| dataSource, events) | ||
|
|
||
| _ = client.EvaluateFlag(t, servicedef.EvaluateFlagParams{FlagKey: prereq1Key, DefaultValue: default1}) |
There was a problem hiding this comment.
Okay @kinyoklion check out this setup I have.
- I explicitly evaluate prereq1Key. This gets added to the summary event, including the default value I provided.
- I then evaluate top level, which has a prereq on prereqs 1 and 2. This results in prereq2 getting added to the summary event without a default value.
- We then evaluate prereq 2 explicitly, which just increments that value, but does not add the default value to the summary counter.
| Variation: o.Some(0), | ||
| FlagVersion: o.Some(1), | ||
| Version: 11, | ||
| Prerequisites: []string{"unknown"}, |
There was a problem hiding this comment.
And yet here we have a prereq on an unknown flag. Once we explicitly evaluate the top level key here, the unknown flag is added to the summary event WITH a default value. What's up with that?
keelerm84
force-pushed
the
mk/sdk-760/prereq-events
branch
from
df768cc to
2d69608
Compare
kinyoklion
approved these changes
Oct 14, 2024
keelerm84
pushed a commit
that referenced
this pull request
Oct 15, 2024
🤖 I have created a release *beep* *boop* --- ## [2.24.0](v2.23.0...v2.24.0) (2024-10-15) ### Features * Add `client-prereq-events` capability ([#242](#242)) ([3172672](3172672)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.