chore: Elevate payload filter to top level data system property #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In FDv1, the payload filter was defined directly on the streaming or polling configuration. While redundant then, it becomes even more so with the FDv2 change. To ensure we are thinking about the payload filter in the same way the SDK handles applying it, we are moving the filter up to act as a data system wide option.
cwaldren-ld
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In FDv1, the payload filter was defined directly on the streaming or
polling configuration. While redundant then, it becomes even more so
with the FDv2 change.
To ensure we are thinking about the payload filter in the same way the
SDK handles applying it, we are moving the filter up to act as a data
system wide option.