last final checks

CRAN-SUBMISSION

@@ -0,0 +1,3 @@
+Version: 0.1.0
+Date: 2023-10-06 12:16:39 UTC
+SHA: 995484a9774331f23ddac53b62c70997768a0c28

DESCRIPTION

@@ -2,7 +2,7 @@ Package: SANple
 Type: Package
 Title: Fitting Common and Shared Atoms Nested Models via MCMC
 Version: 0.1.0
-Date: 2023-09-09
+Date: 2023-10-09
 Authors@R: c(
     person("Laura", "D'Angelo", ,"laura.dangelo@live.com", 
     role = c("aut", "cre", "cph"),
@@ -14,7 +14,11 @@ Authors@R: c(
 Maintainer: Laura D'Angelo <laura.dangelo@live.com>
 URL: https://github.com/laura-dangelo/SANple
 BugReports: https://github.com/laura-dangelo/SANple/issues
-Description: Estimate Bayesian nested mixture models via Markov Chain Monte Carlo methods. Specifically, the package implements the common atoms model (Denti et al., 2023), its finite version (D'Angelo et al., 2023), and a hybrid finite-infinite model. All models use Gaussian mixtures with a normal-inverse-gamma prior distribution on the parameters. Additional functions are provided to help analyzing the results of the fitting procedure.  See:  Denti, Camerlenghi, Guindani, Mira (2023) <doi:10.1080/01621459.2021.1933499>  D’Angelo, Canale, Yu, Guindani (2023) <doi:10.1111/biom.13626>.
+Description: Estimate Bayesian nested mixture models via Markov Chain Monte Carlo methods. Specifically, the package implements the common atoms model (Denti et al., 2023), its finite version (D'Angelo et al., 2023), and a hybrid finite-infinite model. 
+             All models use Gaussian mixtures with a normal-inverse-gamma prior distribution on the parameters. Additional functions are provided to help analyzing the results of the fitting procedure.  
+             References:  
+             Denti, Camerlenghi, Guindani, Mira (2023) <doi:10.1080/01621459.2021.1933499>,   
+             D’Angelo, Canale, Yu, Guindani (2023) <doi:10.1111/biom.13626>.
 License: MIT + file LICENSE
 Imports: 
     Rcpp,

cran-comments.md

@@ -1,8 +1,32 @@
-Please note this is the first submission of this package to CRAN.
+Please note this is a resubmission of this package to CRAN.
+
+Thank you for checking our package. After the inspection, we were notified of the following:
+
+* Please do not start the description with "This package", package name, title or similar.
+
+The new incipit in the description is: "Estimate Bayesian nested mixture models via Markov Chain Monte Carlo methods.[...]".
+
+* Please add some form of linking to your references.
+
+We added the links for the papers we mentioned.
+
+* Please always explain all acronyms in the description text. -> MCMC
+
+Done.
+
+* Please call the on.exit() functions right after defining 'oldpar' and change the option only afterwards.
+
+We corrected the code as requested.
+
+* Please unwrap the examples if that is feasible and if they can be 
+executed in < 5 sec for each Rd file or create additionally small toy 
+examples to allow automatic testing.
+
+All the old examples have been reduced and are now testable. On our machines, the tests took less than a second to run.
 
 ## R CMD check results
 
-- Running `devtools::check(args = c('--as-cran','--no-manual'))` locally produces no errors, no warnings, nor notes.
+- Running `devtools::check(args = c('--as-cran','--no-manual'))` locally produces no errors, warnings, or notes.
 
 - Running `devtools::check(remote = TRUE, manual = TRUE)` produces
 
@@ -13,6 +37,20 @@ Please note this is the first submission of this package to CRAN.
 
   New submission
 
+and
+
+Found the following (possibly) invalid DOIs:
+    DOI: 10.1080/01621459.2021.1933499
+      From: DESCRIPTION
+      Status: Forbidden
+      Message: 403
+    DOI: 10.1111/biom.13626
+      From: DESCRIPTION
+      Status: Forbidden
+      Message: 403
+
+However, the links work when building the documentation.
+
 - Running `devtools::check_win_devel()` produces
 
 0 errors | 0 warnings | 1 note
@@ -22,7 +60,7 @@ Please note this is the first submission of this package to CRAN.
 
   New submission
 
-- Finally, this package, in its current state, also passes all the standard checks performed via *GitHub actions*.
+- Finally, in its current state, this package also passes all the standard checks performed via *GitHub actions*.
 
 ## Downstream dependencies