-
Notifications
You must be signed in to change notification settings - Fork 195
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should split congo into 'congo kinshasa' and 'congo brazza'.
And add more cities in both.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use +
between words instead of spaces. Also, please add documentation or links on the origins of the names, as those of us outside the two regions cannot weigh in here.
@bernard-ng I was talking more about the name of the region itself, "congo" vs "congo brazza". |
Owh agree, there is no particular documentation on the origin of the names, to differentiate the two Congo we often use the capital Congo (kinshasa) => COD |
Or, with more details as you can find it below @ashkulz :
"common": "DR Congo",
"official": "Democratic Republic of the Congo",
"capital": [
"Kinshasa"
],
"altSpellings": [
"CD",
"DR Congo",
"Congo-Kinshasa",
"Congo, the Democratic Republic of the",
"DRC"
],
"region": "Africa" https://restcountries.com/v3.1/alpha/cod
"common": "Republic of the Congo",
"official": "Republic of the Congo",
"capital": [
"Brazzaville"
],
"altSpellings": [
"CG",
"Congo",
"Congo-Brazzaville"
],
"region": "Africa" |
Hmm, I think https://en.wikipedia.org/wiki/Republic_of_the_Congo_(disambiguation) is also a decent explanation and reference. I think you should also change the existing |
- Change congo brazza to it's full name congo brazzaville - Change congo to congo kinshasa to completly make it unambiguous - Add many more cities into kongo kinshasa
@bernard-ng I have made changes to the |
To make it even more clear, this can be spelled |
Thank you Co-authored-by: Ashish Kulkarni <ashish@kulkarni.dev>
Yeah thank you Co-authored-by: Ashish Kulkarni <ashish@kulkarni.dev>
Update country names and add more cites (COD vs COG)
@bernard-ng can you rebase/squash the commits? Also, I think you didn't pickup this commit from @MarienMupenda. |
it's a bit confusing because there are two pull requests, mine and @MarienMupenda's, which is more up to date, I'll close this one so that the other one #171 is taken into account |
There are in fact 2 Congo and this pull request aims to differentiate them in the display of results