Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

#151 differentiate Congo COD and COG #164

Closed
wants to merge 6 commits into from
Closed

#151 differentiate Congo COD and COG #164

wants to merge 6 commits into from

Conversation

bernard-ng
Copy link

There are in fact 2 Congo and this pull request aims to differentiate them in the display of results

Copy link

@MarienMupenda MarienMupenda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should split congo into 'congo kinshasa' and 'congo brazza'.

And add more cities in both.

Copy link

@ashkulz ashkulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use + between words instead of spaces. Also, please add documentation or links on the origins of the names, as those of us outside the two regions cannot weigh in here.

@ashkulz ashkulz mentioned this pull request Jun 6, 2022
@ashkulz
Copy link

ashkulz commented Jun 26, 2022

@bernard-ng I was talking more about the name of the region itself, "congo" vs "congo brazza".

@bernard-ng
Copy link
Author

Owh agree, there is no particular documentation on the origin of the names, to differentiate the two Congo we often use the capital

Congo (kinshasa) => COD
Congo (brazzaville) or Congo (brazza) => COG

@MarienMupenda
Copy link

MarienMupenda commented Jun 26, 2022

Or, with more details as you can find it below @ashkulz :

  1. Democratic Republic of Congo => DR Congo (DRC) => Congo-Kinshasa => COD => CD
"common": "DR Congo",
"official": "Democratic Republic of the Congo",
"capital": [
"Kinshasa"
],
"altSpellings": [
"CD",
"DR Congo",
"Congo-Kinshasa",
"Congo, the Democratic Republic of the",
"DRC"
],
"region": "Africa"

https://restcountries.com/v3.1/alpha/cod

  1. Republic of the Congo (RC) => Congo-Brazzaville => COG => CG
"common": "Republic of the Congo",
"official": "Republic of the Congo",
"capital": [
"Brazzaville"
],

"altSpellings": [
"CG",
"Congo",
"Congo-Brazzaville"
],
"region": "Africa"

https://restcountries.com/v3.1/alpha/cog

@ashkulz
Copy link

ashkulz commented Jun 27, 2022

Hmm, I think https://en.wikipedia.org/wiki/Republic_of_the_Congo_(disambiguation) is also a decent explanation and reference. I think you should also change the existing congo definition and add the above link so that it's clear why it's being done. This will break a few links, but I think that's better than having a confusing name.

- Change congo brazza to it's full name congo brazzaville
- Change congo to congo kinshasa to completly make it unambiguous
- Add many more cities into kongo kinshasa
@MarienMupenda
Copy link

MarienMupenda commented Jun 27, 2022

@bernard-ng I have made changes to the congo definition and added more cities, here is the pull request to your repository https://github.com/bernard-ng/most-active-github-users-counter/pull/1

@MarienMupenda
Copy link

@bernard-ng I was talking more about the name of the region itself, "congo" vs "congo brazza".

To make it even more clear, this can be spelled congo kinshasa vs congo brazzaville

MarienMupenda and others added 3 commits July 8, 2022 20:39
Thank you

Co-authored-by: Ashish Kulkarni <ashish@kulkarni.dev>
Yeah thank you

Co-authored-by: Ashish Kulkarni <ashish@kulkarni.dev>
Update country names and add more cites (COD vs COG)
@ashkulz
Copy link

ashkulz commented Jul 15, 2022

@bernard-ng can you rebase/squash the commits? Also, I think you didn't pickup this commit from @MarienMupenda.

@bernard-ng
Copy link
Author

it's a bit confusing because there are two pull requests, mine and @MarienMupenda's, which is more up to date, I'll close this one so that the other one #171 is taken into account

@bernard-ng bernard-ng closed this Jul 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants