Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CapsLock시 색 변경 #36

Merged
merged 3 commits into from
Feb 9, 2024
Merged

CapsLock시 색 변경 #36

merged 3 commits into from
Feb 9, 2024

Conversation

myoun
Copy link
Contributor

@myoun myoun commented Feb 3, 2024 •
edited
Loading

#31
로컬에서 테스트해보니 정상 작동 합니다.
하지만 몇가지 알려드릴게 있어 남깁니다.

  1. 커서 색 변경을 LanguageCheckService#switchCursorColorByLanguage에서 수행하고 있었는데, CapsLock 색 변경을 추가하려면 기존 서비스에 코드를 추가해야되므로 LanguageCheckServer의 클래스 이름을 CheckService로 변경하였습니다.
  2. 한글/CapsLock(영어)/CapsLock(한글) 세가지 경우를 생각해야 하는데, 따라서 각각 색을 다르게 만들었습니다. 이 과정에서 기존 cursorColor라는 변수의 이름을 nonEnglighCursorColor, 나머지 두개의 이름을 capsLockCursorColor, nonEnglishCapsLockCursorColor로 변경했습니다. 하지만, 이름이 너무 길다는 생각이 들수도 있을 것 같습니다.

제가 수정할 점이 있으면 남겨주세요. 수정하고 커밋하겠습니다.

@myoun myoun changed the base branch from main to develop February 3, 2024 18:16
lauvsong
lauvsong reviewed Feb 7, 2024
View reviewed changes
src/main/kotlin/com/github/lauvsong/langcursor/core/CapsLockCheckStrategy.kt
}

val defaultCapsLockCheckStrategy = CapsLockCheckStrategy {
val capsLock = Toolkit.getDefaultToolkit().getLockingKeyState(KeyEvent.VK_CAPS_LOCK)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이렇게 캡스락을 알아낼 수 있군요 bb
찾아주셔서 감사해요

@myoun
feat: give priority to capslock
a1df6dd 
- removed nonEnglishCapsLockColor
- rename CheckService to InputChecker
@lauvsong lauvsong linked an issue Feb 9, 2024 that may be closed by this pull request
Change cursor color with capslock status #31
Closed
@lauvsong
Copy link
Owner

lauvsong commented Feb 9, 2024

LGTM!! 수정 반영해주셔서 감사해요
머지하고 1.1.0 버전 배포에 포함할게요!

@lauvsong lauvsong merged commit c6000b8 into lauvsong:develop Feb 9, 2024
5 checks passed
lauvsong added a commit that referenced this pull request Feb 9, 2024
@myoun @lauvsong
feat: Change cursor color on Caps Lock activation (#36)
eb1844e 
* CapsLock시 색 변경

* feat: give priority to capslock

- removed nonEnglishCapsLockColor
- rename CheckService to InputChecker

---------

Co-authored-by: Hyesong Kim <wisepine@kakao.com>
@lauvsong lauvsong added this to the 1.1.0 milestone Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lauvsong lauvsong lauvsong requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

Change cursor color with capslock status
2 participants
@myoun @lauvsong