Add bindings for some libraries built in #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrJacz
approved these changes
Jul 3, 2023
There was a problem hiding this comment.
Honestly this is good stuff and i dont really have the right to give that anymore since not touching this project in a long time nor touched a piece of code in years this is basically the way i would've done it so im happy. I appreciate you putting effort into this project despite my tendency to disappear for months and months. ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is only a suggestion that some libraries can have bindings built in to the main library.
This also fixes some issues where the library expects the send function to exist but it may actually not be present.
The library now waits until the next tick after the constructor call to assign a noop function.
Libraries added are:
I am open for suggestions for libraries to support.
This PR introduces breaking changes by removing the dist folder.
The index is now in the root folder along with the lib folder.
This change was necessary because I would have liked the bindings files to be in the root folder.
TypeScript config file was changed to output directly to the root folder.