Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panes #2282

Merged
merged 38 commits into from
Dec 9, 2024
Merged

Panes #2282

merged 38 commits into from
Dec 9, 2024

Conversation

longhotsummer
Copy link
Contributor

@longhotsummer longhotsummer commented Nov 18, 2024 •
edited
Loading

  • pane-based layouts
  • simplify the document editor to have a less hacked layout, and more consistent flex-based layouts
  • splitters between panes that remember their state

https://www.loom.com/share/3cf5f64c33b84fd6bbcf8e3fee6ac8b0

You must run npx webpack after checking this out to update javascript; you may also want to rm -rf staticfiles in your indigo directory.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 18, 2024 •
edited
Loading

Test Results

568 tests  ±0   568 ✅ ±0   4m 19s ⏱️ -7s
 60 suites ±0     0 💤 ±0 
 60 files   ±0     0 ❌ ±0 

Results for commit 92bb5dd. ± Comparison against base commit 57064cb.

♻️ This comment has been updated with latest results.

@longhotsummer
Copy link
Contributor Author

Moved back to a full-edit view experience, but with smarter JS under the hood to pave the way for the next step.

https://www.loom.com/share/088866000ce443d68652ebf20a9411a4

@longhotsummer
Copy link
Contributor Author

Moved back to a full-edit view experience, but with smarter JS under the hood to pave the way for the next step.

https://www.loom.com/share/088866000ce443d68652ebf20a9411a4

ok, bug fixed

longhotsummer and others added 2 commits December 9, 2024 10:03
@longhotsummer @goose-life
Update indigo_app/static/javascript/indigo/views/document_editor.js
cb3b9f6 
Co-authored-by: edith <32566441+goose-life@users.noreply.github.com>
@longhotsummer @goose-life
Update indigo_app/static/javascript/indigo/views/document_editor.js
ed0715f 
Co-authored-by: edith <32566441+goose-life@users.noreply.github.com>
@longhotsummer longhotsummer marked this pull request as ready for review December 9, 2024 11:35
@longhotsummer
Copy link
Contributor Author

Final video https://www.loom.com/share/c68487248caa4f9b83fa05d462837b0f

@longhotsummer longhotsummer merged commit 9f48800 into master Dec 9, 2024
5 checks passed
@longhotsummer longhotsummer deleted the panes branch December 9, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goose-life goose-life goose-life approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@longhotsummer @goose-life