From eb0913a35a855709d90a96328bf74dc1db5b08bd Mon Sep 17 00:00:00 2001 From: laxmanpokhrel Date: Mon, 26 Feb 2024 13:35:02 +0545 Subject: [PATCH 1/3] fix: false == in condition --- .github/workflows/release.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index 377a9da..9db308a 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -111,7 +111,7 @@ jobs: ${{steps.read-release-props.outputs.release-type}} - name: Push and raise a PR - if: ${{steps.read-release-props.outcome.release-type != '--prerelease'}} + if: false == ${{steps.read-release-props.outcome.release-type == '--prerelease'}} env: GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} run: | From 38090ba1f9ceffb33c865a057dea8b1779510128 Mon Sep 17 00:00:00 2001 From: laxmanpokhrel Date: Mon, 26 Feb 2024 15:29:52 +0545 Subject: [PATCH 2/3] fix: outcomes to outputs --- .github/workflows/release.yaml | 2 +- .release/release-notes.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index 9db308a..c5a82aa 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -111,7 +111,7 @@ jobs: ${{steps.read-release-props.outputs.release-type}} - name: Push and raise a PR - if: false == ${{steps.read-release-props.outcome.release-type == '--prerelease'}} + if: ${{steps.read-release-props.outputs.release-type != '--prerelease'}} env: GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} run: | diff --git a/.release/release-notes.md b/.release/release-notes.md index 8880cec..f869e4c 100644 --- a/.release/release-notes.md +++ b/.release/release-notes.md @@ -1,2 +1,2 @@ ## Presease to check if reading release type is working -- no PR in prerelease check with encapsulated condition \ No newline at end of file +- no PR in prerelease check with encapsulated condition with == \ No newline at end of file From fa297292739403658d63118c9d4b248a9668a44a Mon Sep 17 00:00:00 2001 From: laxmanpokhrel Date: Mon, 26 Feb 2024 15:30:06 +0545 Subject: [PATCH 3/3] fix: outcomes to outputs --- .release/release-notes.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.release/release-notes.md b/.release/release-notes.md index f869e4c..b7459d8 100644 --- a/.release/release-notes.md +++ b/.release/release-notes.md @@ -1,2 +1,2 @@ ## Presease to check if reading release type is working -- no PR in prerelease check with encapsulated condition with == \ No newline at end of file +- no PR in prerelease check with encapsulated condition with == and outputs \ No newline at end of file