Add PEP-517 Support #521
Merged
Add PEP-517 Support #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nosracd
force-pushed
the
feature/wheels
branch
3 times, most recently
from
5d61910
to
251423f
Compare
update action name
want it to actually compile stuff
want something top-level
use all versions of scikit-build-core
bump python required to build wheel
scikit_build_core not available on older versions
set -j4
don't include .pc files in wheel
pull windows out of the matrix into its own job specify msys2 shell
latest version has fixes for EOL centOS mirrors
nosracd
force-pushed
the
feature/wheels
branch
2 times, most recently
from
c55ba44
to
649b8ab
Compare
local venv and macOS stuff
bump cibuildwheel
need a version that has a version of manylinux with past EOL centOS mirrors
give up on java on muslinux
cmake can't find javah
no Python3.7 on macos-14 runner
ihilt
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
pyproject.yamlwhich uses thescikit-build-corebackend to build LCM and package it into a wheel. This means that Python users canpip install .to build LCM from source and install it. It also adds a CI job to build a plethora of wheels via cibuildwheel for linux and macOS, both aarch64 and x86_64. This is necessary to resolve #512.Other changes include:
auditwheel)Development.Modulecomponent is looked-for in particular rather than just theDevelopmentcomponent.run_*functions are added to the python module (e.g.run_logplayer_gui). The python package creates a corresponding script which gets put in the mainbin/directory and calls that function. Then that function calls the corresponding LCM script. These shims allow LCM scripts to be on the main path for the Python user.