Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark on buffered channel to save filters to file #15

Open
ylgrgyq opened this issue Dec 4, 2019 · 0 comments
Open

benchmark on buffered channel to save filters to file #15

ylgrgyq opened this issue Dec 4, 2019 · 0 comments

Comments

@ylgrgyq
Copy link
Contributor

ylgrgyq commented Dec 4, 2019

We use regular FileChannel to save filters to file. Maybe we can consider to use buffered channel to improve performance which means write bytes to a buffer first then flush all the cumulative bytes to file.

Because filter is comparatively large, usually several MB, using buffered channel might not have significant improvement. So we need a benchmark first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant