Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cid 2732/authenticate to ghe #2

Merged
merged 6 commits into from
Jul 5, 2024

Conversation

mohamedlajmileanix
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Jun 26, 2024

LeanIX GitHub Agent Code Coverage

File Coverage [82.65%] 🍏
GitHubClient.kt 100% 🍏
GitHubEnterpriseProperties.kt 100% 🍏
GitHubAppResponse.kt 100% 🍏
GitHubEnterpriseService.kt 94.81% 🍏
GitHubAuthenticationService.kt 92.12% 🍏
CachingService.kt 66.41% 🍏
AgentSetupValidation.kt 56.52%
Exceptions.kt 48.28%
GitHubAgentApplication.kt 27.27%
PostStartupRunner.kt 0%
Total Project Coverage 82.65% 🍏

Copy link
Contributor

@geoandri geoandri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a public facing project, maybe is a good idea to follow the GitHub naming pattern in the class and variable names (e.g. gitHub instead of github)

.github/workflows/leanix-github-agent-code-coverage.yml Outdated Show resolved Hide resolved
build.gradle.kts Show resolved Hide resolved
config/detekt/detekt.yml Outdated Show resolved Hide resolved
@mohamedlajmileanix mohamedlajmileanix force-pushed the feature/CID-2732/authenticate-to-ghe branch from 53894be to e116e60 Compare June 28, 2024 14:08
@mohamedlajmileanix mohamedlajmileanix requested a review from a team as a code owner June 28, 2024 14:08
@mohamedlajmileanix mohamedlajmileanix merged commit 56b9cad into main Jul 5, 2024
3 checks passed
@mohamedlajmileanix mohamedlajmileanix added the enhancement New feature or request label Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

3 participants