Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CID-2939: Improve connection error logs. Fix jwtToken variable name. … #25

Merged

Conversation

mohamedlajmileanix
Copy link
Contributor

@mohamedlajmileanix mohamedlajmileanix commented Sep 4, 2024

πŸ›  Changes made

Improve connection error logs.
Fix jwtToken variable name.
Stop the application if it fails to establish websocket connection.

✨ Type of change

Please delete the options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

πŸ§ͺ How Has This Been Tested?

  • Fixed tests
  • No tests added

🏎 Checklist:

  • Assigned the appropriate labels (version, PR type, etc.)

…Stop the application if it fails to establish websocket connection.
@mohamedlajmileanix mohamedlajmileanix added bug Something isn't working enhancement New feature or request labels Sep 4, 2024
Copy link

github-actions bot commented Sep 5, 2024

LeanIX GitHub Agent Code Coverage

File Coverage [48.74%] ❌
PostStartupRunner.kt 93.75% 🍏
WebSocketService.kt 58.02% ❌
BrokerStompSessionHandler.kt 11.21% ❌
Total Project Coverage 66.42% 🍏

@mohamedlajmileanix mohamedlajmileanix marked this pull request as ready for review September 5, 2024 07:21
@mohamedlajmileanix mohamedlajmileanix requested a review from a team as a code owner September 5, 2024 07:21
@mohamedlajmileanix mohamedlajmileanix merged commit 18bc6b6 into main Sep 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants