Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CID-3000: Switch from app name to slug #28

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

mohamedlajmileanix
Copy link
Contributor

πŸ›  Changes made

If the GitHub App name includes special characters, GitHub encodes it in way that is unknown for us. Hence, the agent need to send the GitHub App slug instead of name.

✨ Type of change

Please delete the options that are not relevant.

πŸ§ͺ How Has This Been Tested?

  • πŸ‘Œ No tests required

🏎 Checklist:

  • My code follows the style guidelines
  • I have performed a self-review of my own code
  • My commit message clearly reflects the changes made
  • Assigned the appropriate labels (version, PR type, etc.)

@mohamedlajmileanix mohamedlajmileanix added the bug Something isn't working label Oct 7, 2024
@mohamedlajmileanix mohamedlajmileanix requested a review from a team as a code owner October 7, 2024 08:35
Copy link

github-actions bot commented Oct 7, 2024

LeanIX GitHub Agent Code Coverage

File Coverage [95.14%] 🍏
GitHubAppResponse.kt 100% 🍏
GitHubEnterpriseService.kt 94.98% 🍏
PostStartupRunner.kt 93.75% 🍏
Total Project Coverage 66.94% 🍏

@alfredo-mfaria alfredo-mfaria merged commit 7d0a6db into main Oct 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

4 participants