-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CID-3105: React to manifest file creation via Webhook #32
base: main
Are you sure you want to change the base?
CID-3105: React to manifest file creation via Webhook #32
Conversation
LeanIX GitHub Agent Code Coverage
|
verify(exactly = 1) { | ||
webSocketService.sendMessage( | ||
"/events/manifestFile", | ||
ManifestFileUpdateDto( | ||
"owner/repo", | ||
ManifestFileAction.ADDED, | ||
"content", | ||
"custom/path/added1/$MANIFEST_FILE_NAME" | ||
) | ||
) | ||
} | ||
|
||
verify(exactly = 1) { | ||
webSocketService.sendMessage( | ||
"/events/manifestFile", | ||
ManifestFileUpdateDto( | ||
"owner/repo", | ||
ManifestFileAction.ADDED, | ||
"content", | ||
"custom/path/added2/$MANIFEST_FILE_NAME" | ||
) | ||
) | ||
} | ||
|
||
verify(exactly = 1) { | ||
webSocketService.sendMessage( | ||
"/events/manifestFile", | ||
ManifestFileUpdateDto( | ||
"owner/repo", | ||
ManifestFileAction.MODIFIED, | ||
"content", | ||
"custom/path/modified/$MANIFEST_FILE_NAME" | ||
) | ||
) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if the order is important here. but if it is, we should use verifyOrder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can group all like this also:
verify(exactly = 1) {
webSocketService.sendMessage(1)
webSocketService.sendMessage(2)
webSocketService.sendMessage(3)
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ahmed-ali-55 thank you for the note but the order is not relevant here. I grouped them as @henriq-amaral-leanix suggested.
🛠 Changes made
React to manifest file creation and update via Webhook, regardless of the location of the manifest file and supporting multiple manifest files within a single repository.
✨ Type of change
🧪 How Has This Been Tested?
🏎 Checklist: