fix: remove List.erase_of_forall_bne and replace with List.erase_eq_self_iff_forall_bne #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Sep 27, 2024
|
Mathlib CI status (docs):
|
fgdorais
changed the title
Merged
via the queue into
leanprover-community:main
with commit Sep 28, 2024
8311edc
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking at the TODO in my recently merged PR I realized that it's obsolete now, as the mentioned theorem already exists in core as its iff variant.
That motivated me to convert the theorem I added to its iff version. I guess this is a breaking change, but since the PR was just merged yesterday, the only usage of the theorem is probably in Array/Lemmas.