feat: add Mersenne Twister PRNG #984
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgdorais
force-pushed
the
mersenne-twister
branch
from
ecd24e6
to
b5c9d8e
Compare
fgdorais
changed the title
digama0
reviewed
Oct 12, 2024
digama0
reviewed
Oct 12, 2024
fgdorais
force-pushed
the
mersenne-twister
branch
from
d8dc98a
to
b2f598a
Compare
fgdorais
force-pushed
the
mersenne-twister
branch
from
b2f598a
to
616ae86
Compare
digama0
reviewed
Oct 13, 2024
|
Needs a test file and/or usage example in the docs, otherwise LGTM |
fgdorais
added
the
depends on another PR
fgdorais
added
awaiting-review
|
@digama0 I think this is ready for "final" review. I added docs and tests. The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dropandtakefor streams #985 (for testing only)TODO:
The implementation is very general. Probably still reasonably efficient but we could link to an optimized external implementation for the standard MT19937 and MT19937-64 algorithms.