Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(Algebra/Order/Field/Basic): add Nat cast lemmas #18171

Closed
wants to merge 3 commits into from

Conversation

mariainesdff
Copy link
Collaborator

These lemmas have one-line proofs, but I use them enough times in #15373 that I think it makes sense to introduce them.


Open in Gitpod

@mariainesdff mariainesdff added the t-algebra Algebra (groups, rings, fields, etc) label Oct 24, 2024
Copy link

github-actions bot commented Oct 24, 2024

PR summary a28a96dda8

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ one_div_cast_ne_zero
+ one_div_cast_nonneg
+ one_div_cast_pos

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

Copy link
Collaborator

@j-loreaux j-loreaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these belong in Mathlib.Data.Nat.Cast.Order.Field

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 24, 2024

✌️ mariainesdff can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@mariainesdff
Copy link
Collaborator Author

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Oct 28, 2024
These lemmas have one-line proofs, but I use them enough times in #15373 that I think it makes sense to introduce them.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 28, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Algebra/Order/Field/Basic): add Nat cast lemmas [Merged by Bors] - feat(Algebra/Order/Field/Basic): add Nat cast lemmas Oct 28, 2024
@mathlib-bors mathlib-bors bot closed this Oct 28, 2024
@mathlib-bors mathlib-bors bot deleted the mariainesdff/nat_cast branch October 28, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated t-algebra Algebra (groups, rings, fields, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants