Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(LinearAlgebra/BilinearForm/TensorProduct): Tensor products of bilinear maps #14988

Open
wants to merge 66 commits into
base: master
Choose a base branch
from

Conversation

mans0954
Copy link
Collaborator

@mans0954 mans0954 commented Jul 21, 2024

Extend the results in Mathlib/LinearAlgebra/BilinearForm/TensorProduct.lean from Bilinear Forms to Bilinear Maps

Similarly for LinearAlgebra/QuadraticForm/TensorProduct.

I had originally intended to extend much more, but was blocked by not being able to extend LinearMap.IsSymm from forms to maps.


Open in Gitpod

@mans0954 mans0954 added the WIP Work in progress label Jul 21, 2024
Copy link

github-actions bot commented Jul 21, 2024

PR summary 21ea33a912

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.LinearAlgebra.BilinearForm.TensorProduct 1275 1277 +2 (+0.16%)
Mathlib.LinearAlgebra.QuadraticForm.TensorProduct 1308 1310 +2 (+0.15%)
Mathlib.LinearAlgebra.CliffordAlgebra.BaseChange 1325 1327 +2 (+0.15%)
Import changes for all files
Files Import difference
6 files Mathlib.LinearAlgebra.QuadraticForm.QuadraticModuleCat.Symmetric Mathlib.LinearAlgebra.QuadraticForm.QuadraticModuleCat.Monoidal Mathlib.LinearAlgebra.BilinearForm.TensorProduct Mathlib.LinearAlgebra.CliffordAlgebra.BaseChange Mathlib.LinearAlgebra.QuadraticForm.TensorProduct Mathlib.LinearAlgebra.QuadraticForm.TensorProduct.Isometries
2

Declarations diff

+ exists_quadraticMap_ne_zero
++ tensorDistrib
++ tensorDistrib_tmul
++- baseChange
++- baseChange_tmul
+-++ tmul

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@mans0954 mans0954 marked this pull request as ready for review July 22, 2024 21:35
@mans0954 mans0954 removed the WIP Work in progress label Jul 22, 2024
@mans0954
Copy link
Collaborator Author

CC: @eric-wieser

@mans0954 mans0954 changed the title refactor(Mathlib/LinearAlgebra/BilinearForm/TensorProduct.lean): Tensor products of bilinear maps refactor(LinearAlgebra/BilinearForm/TensorProduct): Tensor products of bilinear maps Jul 22, 2024
@mans0954 mans0954 added the t-algebra Algebra (groups, rings, fields, etc) label Jul 30, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Aug 7, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Aug 7, 2024
@mans0954
Copy link
Collaborator Author

mans0954 commented Aug 8, 2024

@eric-wieser did you have any further thoughts on this please?

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Aug 9, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 24, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 24, 2024
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fill out the "moves" section of the PR template to indicate that BilinMap.tmul and friends have moved to BilinForm.tmul?

Mathlib/LinearAlgebra/QuadraticForm/TensorProduct.lean Outdated Show resolved Hide resolved
Mathlib/LinearAlgebra/BilinearForm/TensorProduct.lean Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-algebra Algebra (groups, rings, fields, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants