-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(FieldTheory/Minpoly): minpoly K x splits implies minpoly K (algebraMap K L a - x) splits #17369
Open
jjdishere
wants to merge
204
commits into
master
Choose a base branch
from
jiedong_jiang_neg_split
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+136
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
jjdishere
removed
the
merge-conflict
The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot)
label
Oct 21, 2024
leanprover-community-bot-assistant
added
the
merge-conflict
The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot)
label
Oct 22, 2024
jjdishere
removed
the
merge-conflict
The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot)
label
Oct 23, 2024
alreadydone
reviewed
Oct 23, 2024
alreadydone
reviewed
Oct 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency:
Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
jjdishere
added
the
awaiting-author
A reviewer has asked the author a question or requested changes
label
Oct 24, 2024
alreadydone
reviewed
Oct 25, 2024
jjdishere
removed
the
awaiting-author
A reviewer has asked the author a question or requested changes
label
Oct 27, 2024
leanprover-community-bot-assistant
added
the
merge-conflict
The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot)
label
Oct 28, 2024
jjdishere
removed
the
merge-conflict
The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot)
label
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
blocked-by-other-PR
This PR depends on another PR to Mathlib (this label is automatically managed by a bot)
new-contributor
This PR was made by a contributor with a most 5 merged PRs. Welcome to the community!
t-algebra
Algebra (groups, rings, fields, etc)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
minpoly K x
splits impliesminpoly K (- x)
splits andminpoly K (algebraMap K L a - x)
splits. This is after #17093 .minpoly K x
splits impliesminpoly K (x + algebraMap K L a)
splits #17093