Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: ZMod-module lemmas #17693

Closed
wants to merge 8 commits into from
Closed

Conversation

YaelDillies
Copy link
Collaborator

From PFR


I am not a huge fan of the names I came up with, so I would gladly take suggestions.

Open in Gitpod

@YaelDillies YaelDillies added the t-algebra Algebra (groups, rings, fields, etc) label Oct 13, 2024
Copy link

github-actions bot commented Oct 13, 2024

PR summary 5016bbbb2b

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ ZModModule.add_add_add_cancel
+ ZModModule.add_self
+ ZModModule.char_ne_one
+ ZModModule.char_nsmul_eq_zero
+ ZModModule.neg_eq_self
+ ZModModule.periodicPts_add_left
+ ZModModule.sub_eq_add
+ ZModModule.two_le_char

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@github-actions github-actions bot added the t-data Data (lists, quotients, numbers, etc) label Oct 13, 2024
@YaelDillies YaelDillies removed the t-data Data (lists, quotients, numbers, etc) label Oct 13, 2024
@jcommelin jcommelin added the awaiting-author A reviewer has asked the author a question or requested changes label Oct 17, 2024
@YaelDillies YaelDillies removed the awaiting-author A reviewer has asked the author a question or requested changes label Oct 17, 2024
@jcommelin jcommelin added the awaiting-author A reviewer has asked the author a question or requested changes label Oct 26, 2024
@YaelDillies YaelDillies removed the awaiting-author A reviewer has asked the author a question or requested changes label Oct 27, 2024
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 28, 2024

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@YaelDillies
Copy link
Collaborator Author

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Oct 28, 2024
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 28, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: ZMod-module lemmas [Merged by Bors] - feat: ZMod-module lemmas Oct 28, 2024
@mathlib-bors mathlib-bors bot closed this Oct 28, 2024
@mathlib-bors mathlib-bors bot deleted the zmod_module branch October 28, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated t-algebra Algebra (groups, rings, fields, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants