chore(FieldTheory/RatFunc): clean up porting notes #18001
+102
−169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vierkantor
added
t-algebra
PR summary 8a56cc7cabImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for |
leanprover-community-bot-assistant
added
the
merge-conflict
I saw `RatFunc.Defs` and `RatFunc.Basic` were full of porting notes, so I went through and cleaned up the files. Mostly I tried to redo proofs that became messy during the port.
Vierkantor
force-pushed
the
cleanup-RatFunc
branch
from
403c21e
to
6c1ec8e
Compare
leanprover-community-bot-assistant
removed
the
merge-conflict
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw
RatFunc.DefsandRatFunc.Basicwere full of porting notes, so I went through and cleaned up the files. Mostly I tried to redo proofs that became messy during the port.