Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Topology/Algebra/Field): ContinuousSMul for intermediate fields #18142

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

jjdishere
Copy link
Collaborator

@jjdishere jjdishere commented Oct 23, 2024

If M is an intermediate field between field extension L/K, then M acts continuously on L and bot act continuously on M. The M acts continuously on L part is proved in a more general setup.


@jjdishere jjdishere added awaiting-CI t-topology Topological spaces, uniform spaces, metric spaces, filters t-algebra Algebra (groups, rings, fields, etc) labels Oct 23, 2024
@github-actions github-actions bot added the large-import Automatically added label for PRs with a significant increase in transitive imports label Oct 23, 2024
Copy link

github-actions bot commented Oct 23, 2024

PR summary f47c38cd66

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Topology.Algebra.IntermediateField 1382

Declarations diff

+ IntermediateField.botContinuousSMul
+ IntermediateField.continuousSMul
+ Subalgebra.continuousSMul
+ Subfield.continuousSMul
+ Subring.continuousSMul
+ continuousSMul

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@jjdishere
Copy link
Collaborator Author

jjdishere commented Oct 23, 2024

The large import change is caused by the bot element of IntermediateField being defined unexpectedly late. It could be defined as early as in the file containing IntermediateField's definition. However, it is not defined until the file Mathlib.FieldTheory.Adjoin.

In order to solve this, I created a new file specialized for the ContinuousSMul instances for intermediate fields.

@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Oct 23, 2024
@jjdishere jjdishere removed the large-import Automatically added label for PRs with a significant increase in transitive imports label Oct 23, 2024
@jjdishere
Copy link
Collaborator Author

!bench

@jjdishere jjdishere added the large-import Automatically added label for PRs with a significant increase in transitive imports label Oct 23, 2024
@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit 774ee5e.
The entire run failed.
Found no significant differences.

move lemmas

typo

fix large import
@jjdishere jjdishere force-pushed the jiedong_jiang_continuous_smul_intermediate_field' branch from 4dd0f13 to b5bd4dd Compare October 23, 2024 18:11
@github-actions github-actions bot removed the large-import Automatically added label for PRs with a significant increase in transitive imports label Oct 23, 2024
@jjdishere
Copy link
Collaborator Author

!bench

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit b0efef1.
There were significant changes against commit e98856a:

  Benchmark                                          Metric         Change
  ========================================================================
- ~Mathlib.FieldTheory.Galois.Profinite              instructions    30.9%
+ ~Mathlib.FieldTheory.IntermediateField.Algebraic   instructions   -22.7%
- ~Mathlib.FieldTheory.IntermediateField.Basic       instructions     8.8%
+ ~Mathlib.NumberTheory.NumberField.Discriminant     instructions    -7.9%

Copy link

File Instructions %
build -560.257⬝10⁹ (+0.42%)
lint -103.439⬝10⁹ (+1.57%)
Mathlib.FieldTheory.Galois.Profinite +14.239⬝10⁹ (+30.85%)
Mathlib.FieldTheory.IntermediateField.Basic +10.692⬝10⁹ (+8.80%)
2 files, Instructions +4.0⬝10⁹
File Instructions %
Mathlib.Algebra.Field.Subfield +4.200⬝10⁹ (+7.24%)
Mathlib.RepresentationTheory.GroupCohomology.Resolution +4.103⬝10⁹ (+2.81%)
4 files, Instructions +1.0⬝10⁹
File Instructions %
Mathlib.FieldTheory.SeparableDegree +1.914⬝10⁹ (+1.20%)
Mathlib.FieldTheory.Fixed +1.441⬝10⁹ (+1.48%)
Mathlib.FieldTheory.PrimitiveElement +1.301⬝10⁹ (+2.29%)
Mathlib.Topology.Algebra.Ring.Basic +1.24⬝10⁹ (+7.74%)
2 files, Instructions -2.0⬝10⁹
File Instructions %
Mathlib.FieldTheory.PurelyInseparable -1.24⬝10⁹ (+0.50%)
Mathlib.FieldTheory.PolynomialGaloisGroup -1.646⬝10⁹ (+3.77%)
2 files, Instructions -4.0⬝10⁹
File Instructions %
Mathlib.RingTheory.Trace.Basic -3.153⬝10⁹ (+3.73%)
Mathlib.NumberTheory.Cyclotomic.PrimitiveRoots -3.974⬝10⁹ (+5.52%)
File Instructions %
Mathlib.RingTheory.Norm.Basic -4.456⬝10⁹ (+7.56%)
2 files, Instructions -6.0⬝10⁹
File Instructions %
Mathlib.FieldTheory.SeparableClosure -5.254⬝10⁹ (+8.8%)
Mathlib.FieldTheory.Galois.Basic -5.917⬝10⁹ (+6.95%)
File Instructions %
Mathlib.FieldTheory.Adjoin -6.71⬝10⁹ (+2.20%)
Mathlib.FieldTheory.IntermediateField.Algebraic -11.941⬝10⁹ (+22.68%)
Mathlib.NumberTheory.NumberField.Discriminant -17.290⬝10⁹ (+7.94%)

@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Oct 28, 2024
@mathlib4-dependent-issues-bot
Copy link
Collaborator

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 28, 2024
@jjdishere jjdishere removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-algebra Algebra (groups, rings, fields, etc) t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants