Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NumberField/CanonicalEmbedding): define the negAt map #18234

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

xroblot
Copy link
Collaborator

@xroblot xroblot commented Oct 25, 2024

Let s be a set of real places of the number field K. This PR defines the map negAt s on mixedSpace K that swaps the sign at all real places in s and proves some of its properties.

It will be used later in #18231.

This PR is part of the proof of the Analytic Class Number Formula.


Open in Gitpod

Copy link

github-actions bot commented Oct 25, 2024

PR summary b2c24ffa4c

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.NumberTheory.NumberField.CanonicalEmbedding.Basic 2245 2252 +7 (+0.31%)
Import changes for all files
Files Import difference
3 files Mathlib.NumberTheory.NumberField.EquivReindex Mathlib.NumberTheory.NumberField.House Mathlib.NumberTheory.NumberField.CanonicalEmbedding.Basic
7

Declarations diff

+ coe_neg
+ instance : IsAddHaarMeasure (volume : Measure (mixedSpace K))
+ neg
+ negAt
+ negAt_apply_abs_of_isReal
+ negAt_apply_of_isComplex
+ negAt_apply_of_isReal_and_mem
+ negAt_apply_of_isReal_and_not_mem
+ negAt_apply_snd
+ negAt_signSet_apply_of_isComplex
+ negAt_signSet_apply_of_isReal
+ negAt_symm
+ neg_apply
+ normAtPlace_negAt
+ norm_negAt
+ piCongrRight
+ piCongrRight_apply
+ piCongrRight_symm_apply
+ refl_apply
+ signSet
+ symm_neg
+ volume_preserving_negAt
- instance : IsAddHaarMeasure (volume : Measure (mixedSpace K)) := prod.instIsAddHaarMeasure _ _

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@xroblot xroblot added the t-number-theory Number theory (also use t-algebra or t-analysis to specialize) label Oct 25, 2024
Copy link
Collaborator

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde.

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 28, 2024

✌️ xroblot can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

Copy link
Member

@riccardobrasca riccardobrasca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Mathlib/Topology/Algebra/Module/Basic.lean Outdated Show resolved Hide resolved
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 28, 2024
@riccardobrasca
Copy link
Member

There is a merge conflict but otherwise I think it is ready to go.

@riccardobrasca riccardobrasca removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 28, 2024
@riccardobrasca
Copy link
Member

Thanks!

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated maintainer-merge ready-to-merge This PR has been sent to bors. t-number-theory Number theory (also use t-algebra or t-analysis to specialize)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants