-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NumberField/CanonicalEmbedding): define the negAt
map
#18234
base: master
Are you sure you want to change the base?
Conversation
PR summary b2c24ffa4c
|
File | Base Count | Head Count | Change |
---|---|---|---|
Mathlib.NumberTheory.NumberField.CanonicalEmbedding.Basic | 2245 | 2252 | +7 (+0.31%) |
Import changes for all files
Files | Import difference |
---|---|
3 filesMathlib.NumberTheory.NumberField.EquivReindex Mathlib.NumberTheory.NumberField.House Mathlib.NumberTheory.NumberField.CanonicalEmbedding.Basic |
7 |
Declarations diff
+ coe_neg
+ instance : IsAddHaarMeasure (volume : Measure (mixedSpace K))
+ neg
+ negAt
+ negAt_apply_abs_of_isReal
+ negAt_apply_of_isComplex
+ negAt_apply_of_isReal_and_mem
+ negAt_apply_of_isReal_and_not_mem
+ negAt_apply_snd
+ negAt_signSet_apply_of_isComplex
+ negAt_signSet_apply_of_isReal
+ negAt_symm
+ neg_apply
+ normAtPlace_negAt
+ norm_negAt
+ piCongrRight
+ piCongrRight_apply
+ piCongrRight_symm_apply
+ refl_apply
+ signSet
+ symm_neg
+ volume_preserving_negAt
- instance : IsAddHaarMeasure (volume : Measure (mixedSpace K)) := prod.instIsAddHaarMeasure _ _
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>
The doc-module for script/declarations_diff.sh
contains some details about this script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maintainer merge
🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors d+
✌️ xroblot can now approve this pull request. To approve and merge a pull request, simply reply with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There is a merge conflict but otherwise I think it is ready to go. |
Thanks! bors merge |
Let
s
be a set of real places of the number fieldK
. This PR defines the mapnegAt s
onmixedSpace K
that swaps the sign at all real places ins
and proves some of its properties.It will be used later in #18231.
This PR is part of the proof of the Analytic Class Number Formula.