Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Wiedijk100Theorems): roots of a quartic #18290

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

hanwenzhu
Copy link
Collaborator

@hanwenzhu hanwenzhu commented Oct 27, 2024

  • Added quartic_eq_zero_iff which gives the roots of the quartic equation in terms of a root u to a particular cubic equation, and a degenerate case quartic_eq_zero_iff_of_q_eq_zero
  • Simplified the cubic proof

Open in Gitpod

Copy link

github-actions bot commented Oct 27, 2024

PR summary 29e425fab0

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ cubic_depressed_eq_zero_iff
+ quartic_depressed_eq_zero_iff
+ quartic_eq_zero_iff
+ quartic_eq_zero_iff_of_q_eq_zero
- cubic_basic_eq_zero_iff
- cubic_monic_eq_zero_iff

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@hanwenzhu hanwenzhu added the t-algebra Algebra (groups, rings, fields, etc) label Oct 27, 2024
@Ruben-VandeVelde
Copy link
Collaborator

Meta-point: it's unfortunate that git doesn't recognize that you're moving the cubic. Would you mind creating a separate PR with just the changes to the cubic?

@hanwenzhu
Copy link
Collaborator Author

@Ruben-VandeVelde It's probably also because I changed the file too much. By adding the quartic proof, the file is changed more than 50% so git can't recognize it. I also tested locally if I commit changes to the cubic, and then move to a new file with added quartic, git still can't recognize the name change. Perhaps I can do a separate PR that only contains a file rename to SolutionOfCubicQuartic.lean and changes to the cubic, and in this PR add the quartic proof?

@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Oct 27, 2024
mathlib-bors bot pushed a commit that referenced this pull request Oct 28, 2024
* Shortened the cubic formula proof by removing unnecessary `cubic_monic_eq_zero_iff`
* Renamed `basic` to `depressed`
* Added clearer module docstring
* Renamed the file to SolutionToCubicQuartic, so that #18290 can show correct diffs
mathlib-bors bot pushed a commit that referenced this pull request Oct 28, 2024
* Shortened the cubic formula proof by removing unnecessary `cubic_monic_eq_zero_iff`
* Renamed `basic` to `depressed`
* Added clearer module docstring
* Renamed the file to SolutionToCubicQuartic, so that #18290 can show correct diffs
mathlib-bors bot pushed a commit that referenced this pull request Oct 28, 2024
* Shortened the cubic formula proof by removing unnecessary `cubic_monic_eq_zero_iff`
* Renamed `basic` to `depressed`
* Added clearer module docstring
* Renamed the file to SolutionToCubicQuartic, so that #18290 can show correct diffs
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Oct 28, 2024
@mathlib4-dependent-issues-bot
Copy link
Collaborator

This PR/issue depends on:

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) t-algebra Algebra (groups, rings, fields, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants