-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Wiedijk100Theorems): roots of a quartic #18290
base: master
Are you sure you want to change the base?
Conversation
PR summary 29e425fab0Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
Meta-point: it's unfortunate that git doesn't recognize that you're moving the cubic. Would you mind creating a separate PR with just the changes to the cubic? |
@Ruben-VandeVelde It's probably also because I changed the file too much. By adding the quartic proof, the file is changed more than 50% so git can't recognize it. I also tested locally if I commit changes to the cubic, and then move to a new file with added quartic, git still can't recognize the name change. Perhaps I can do a separate PR that only contains a file rename to SolutionOfCubicQuartic.lean and changes to the cubic, and in this PR add the quartic proof? |
* Shortened the cubic formula proof by removing unnecessary `cubic_monic_eq_zero_iff` * Renamed `basic` to `depressed` * Added clearer module docstring * Renamed the file to SolutionToCubicQuartic, so that #18290 can show correct diffs
* Shortened the cubic formula proof by removing unnecessary `cubic_monic_eq_zero_iff` * Renamed `basic` to `depressed` * Added clearer module docstring * Renamed the file to SolutionToCubicQuartic, so that #18290 can show correct diffs
* Shortened the cubic formula proof by removing unnecessary `cubic_monic_eq_zero_iff` * Renamed `basic` to `depressed` * Added clearer module docstring * Renamed the file to SolutionToCubicQuartic, so that #18290 can show correct diffs
This PR/issue depends on: |
quartic_eq_zero_iff
which gives the roots of the quartic equation in terms of a rootu
to a particular cubic equation, and a degenerate casequartic_eq_zero_iff_of_q_eq_zero