-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(Algebra/Module): presentation of modules #18295
Conversation
PR summary 4c36db383dImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice!
Some feature request & design choice questions.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Thanks very much @erdOne for the review! |
LGTM |
🚀 Pull request has been placed on the maintainer queue by erdOne. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Left 1 comment
bors d+
✌️ joelriou can now approve this pull request. To approve and merge a pull request, simply reply with |
Thanks! bors merge |
This PR defines a basic API for the description of modules in terms of generators and relations. Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
Pull request successfully merged into master. Build succeeded: |
This PR defines a basic API for the description of modules in terms of generators and relations.