Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(Algebra/Module): presentation of modules #18295

Closed
wants to merge 14 commits into from

Conversation

joelriou
Copy link
Collaborator

@joelriou joelriou commented Oct 27, 2024

This PR defines a basic API for the description of modules in terms of generators and relations.


Open in Gitpod

@joelriou joelriou added WIP Work in progress t-algebra Algebra (groups, rings, fields, etc) labels Oct 27, 2024
Copy link

github-actions bot commented Oct 27, 2024

PR summary 4c36db383d

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Algebra.Module.Presentation.Basic 892

Declarations diff

+ IsPresentation
+ Presentation
+ Quotient
+ Relations
+ Solution
+ desc
+ desc_var
+ exact
+ fromQuotient
+ fromQuotient_comp_toQuotient
+ fromQuotient_mk
+ ker_toQuotient
+ ker_π
+ linearEquiv
+ linearEquiv_apply
+ linearEquiv_symm_var
+ linearMapEquiv
+ map
+ mapToKer
+ mapToKer_coe
+ map_single
+ ofQuotient
+ ofQuotient_fromQuotient
+ ofQuotient_isPresentation
+ ofQuotient_π
+ ofπ
+ ofπ'
+ ofπ'_π
+ ofπ_π
+ postcomp
+ postcomp_injective
+ range_map
+ span_relation_le_ker_π
+ surjective_mapToKer
+ surjective_toQuotient
+ surjective_π
+ toQuotient
+ toQuotient_relation
+ π
+ π_comp_map
+ π_comp_map_apply
+ π_relation
+ π_single

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@joelriou joelriou removed the WIP Work in progress label Oct 27, 2024
Copy link
Member

@erdOne erdOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice!
Some feature request & design choice questions.

Mathlib/Algebra/Module/Presentation/Basic.lean Outdated Show resolved Hide resolved
@erdOne erdOne added the awaiting-author A reviewer has asked the author a question or requested changes label Oct 27, 2024
@joelriou
Copy link
Collaborator Author

Thanks very much @erdOne for the review!

@joelriou joelriou removed the awaiting-author A reviewer has asked the author a question or requested changes label Oct 27, 2024
@erdOne erdOne added the awaiting-author A reviewer has asked the author a question or requested changes label Oct 28, 2024
@joelriou joelriou removed the awaiting-author A reviewer has asked the author a question or requested changes label Oct 28, 2024
@erdOne
Copy link
Member

erdOne commented Oct 28, 2024

LGTM
maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by erdOne.

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Left 1 comment

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 28, 2024

✌️ joelriou can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@joelriou
Copy link
Collaborator Author

Thanks!

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Oct 28, 2024
mathlib-bors bot pushed a commit that referenced this pull request Oct 28, 2024
This PR defines a basic API for the description of modules in terms of generators and relations.



Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 28, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Algebra/Module): presentation of modules [Merged by Bors] - feat(Algebra/Module): presentation of modules Oct 28, 2024
@mathlib-bors mathlib-bors bot closed this Oct 28, 2024
@mathlib-bors mathlib-bors bot deleted the unbundled-module-presentation branch October 28, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated maintainer-merge ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants