Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: some erws that can become rw for free #18322

Closed
wants to merge 1 commit into from

Conversation

Vierkantor
Copy link
Contributor

The erw linter of #17638 spotted two erws that can be turned into rw for free.


Open in Gitpod

@Vierkantor Vierkantor added the tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip label Oct 28, 2024
@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Oct 28, 2024
Copy link

PR summary db94b8b086

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@grunweg
Copy link
Collaborator

grunweg commented Oct 28, 2024

Thanks!
maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by grunweg.

@kim-em
Copy link
Contributor

kim-em commented Oct 28, 2024

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Oct 28, 2024
mathlib-bors bot pushed a commit that referenced this pull request Oct 28, 2024
The `erw` linter of #17638 spotted two `erw`s that can be turned into `rw` for free.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 28, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: some erws that can become rw for free [Merged by Bors] - chore: some erws that can become rw for free Oct 28, 2024
@mathlib-bors mathlib-bors bot closed this Oct 28, 2024
@mathlib-bors mathlib-bors bot deleted the unerw-MonoidAlgebra branch October 28, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer-merge ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc) tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants