BLOCKED: feat: withInstantiatMainGoal combinator to eagerly instantiate goal metavariables
#212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an write to memory or a write to a register that is not SP is made, we update the proof of stack alignment. When a write to SP is made, we create a new mvar with the proof obligation that the new value is aligned, and store that mvar in a new `sideConditions` field.
These tags show up in the profile (unlike the message itself)
This help when profiling `sym_n`, because the threshold is applied to each step individually
…t of mvar instantiation
It's allowed to reassign a meta-variable, so there's no need to create a new goal
alexkeizer
changed the title
withInstantiatMainGoal combinator to eagerly instantiate goal metavariableswithInstantiatMainGoal combinator to eagerly instantiate goal metavariables
|
This was added to gather data on why instantiating mvars is so slow, but seemed to have little to no effect, so I'm closing the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
WORK IN PROGRESS.
Attempt to spread out the cost of mvar instantiation by eagerly instantiating the original main goal of
sym_n, after the tactic is finished. This doesn't seem to have any effect.See also the related issue on Lean: leanprover/lean4#5610
Testing:
What tests have been run? Did
make allsucceed for your changes? Wasconformance testing successful on an Aarch64 machine?
License:
By submitting this pull request, I confirm that my contribution is
made under the terms of the Apache 2.0 license.