fix: pass CMAKE_C/CXX_COMPILER to all stages #3080
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #2863, making a guess as to how that should be done. We replace the
if/else/else
withif/else;if
so thatCMAKE_C/CXX_COMPILER
is stored both inPLATFORM_ARGS
andCL_ARGS
and consequently passed to all stages. I am not sure what the original intent of the logic was, but the comment below makes it sound like this was indeed a bug.Link to
RFC
orbug
issue: #2863