-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove unused deriving handler argument syntax #5265
base: master
Are you sure you want to change the base?
chore: remove unused deriving handler argument syntax #5265
Conversation
As far as I can tell, the ability to pass a structure instance to a deriving handler is not actually used in practice. Do we want to remove this, or do we want to use and document it?
Mathlib CI status (docs):
|
Mathlib CI status (docs):
|
From what I can read here, the Mathlib breakage is only due to a deprecation warning being issued, and not that it doesn't compile, right? If so, I take that as evidence that this syntax is indeed not used and can be removed. |
Right. |
As far as I can tell, the ability to pass a structure instance to a deriving handler is not actually used in practice. It didn't seem to be used in the test suite, at least.
Do we want to remove this, or do we want to use and document it? This PR removes it, but that's not something I feel strongly about - but seeing if it breaks Mathlib is a useful data point.