feat: add DecidableRel instances for BitVec #5488
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We follow the recipe for `Decidable` and create a decidable instance for any bitvector width. This was motivated in a case-bash that was used to prove an `sdiv` lemma at width 1. However, due to file ordering constraints, we cannot we use the `DecidableRel` machinery to implement the lemma `sdiv_eq_and`.
|
Ah, right, these can just be inferred by type class synthesis. No need to define these explicitly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We follow the recipe of the
Decidableinstance for bitvectors and create aDecidableRelationinstance,This was motivated by a case-bash that was used to prove a
sdivlemma at width 1. However, due to file ordering constraints, we cannot use theDecidableRelmachinery to implement the lemmasdiv_eq_and.Regardless, we upstream the
DecidableRelmachinery for future use.