chore: use separate secrets for commenting and branching in pr-release.yml #5490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
lean-lang.org/lean4/doc
github-actions
bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
nomeata
reviewed
Sep 27, 2024
| @@ -164,7 +164,7 @@ jobs: | |||
|
|
|||
| # Use GitHub API to check if a comment already exists | |||
| existing_comment="$(curl --retry 3 --location --silent \ | |||
| -H "Authorization: token ${{ secrets.MATHLIB4_BOT }}" \ | |||
| -H "Authorization: token ${{ secrets.MATHLIB4_COMMENT_BOT }}" \ | |||
| -H "Accept: application/vnd.github.v3+json" \ | |||
| "https://api.github.com/repos/leanprover/lean4/issues/${{ steps.workflow-info.outputs.pullRequestNumber }}/comments" \ | |||
| | jq 'first(.[] | select(.body | test("^- . Mathlib") or startswith("Mathlib CI status")) | select(.user.login == "leanprover-community-mathlib4-bot"))')" | |||
There was a problem hiding this comment.
This line needs to be adjusted like in https://github.com/leanprover-community/mathlib4/pull/17182/files
There was a problem hiding this comment.
Suggested change
| | jq 'first(.[] | select(.body | test("^- . Mathlib") or startswith("Mathlib CI status")) | select(.user.login == "leanprover-community-mathlib4-bot"))')" | |
| | jq 'first(.[] | select(.body | test("^- . Mathlib") or startswith("Mathlib CI status")) | select(.user.login == "leanprover-community-bot"))')" |
nomeata
added a commit
that referenced
this pull request
Sep 27, 2024
This didn’t make it in with #5490, but seems to be needed, just as in https://github.com/leanprover-community/mathlib4/pull/17182/files (the code is duplicated in both repos, and should be the same).
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 27, 2024
This didn’t make it in with #5490, but seems to be needed, just as in https://github.com/leanprover-community/mathlib4/pull/17182/files (the code is duplicated in both repos, and should be the same).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this will resolve the problem of duplicated comments when the bots post about Mathlib CI status.