Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git conflict experiment #5500

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Git conflict experiment #5500

wants to merge 4 commits into from

Conversation

kmill
Copy link
Collaborator

@kmill kmill commented Sep 27, 2024

This is an experiment to have git conflict syntax be processed like comments.

The option parser.git.useIncoming controls whether to use the incoming or current versions.

@jcommelin @adomani

@github-actions github-actions bot added the changes-stage0 Contains stage0 changes, merge manually using rebase label Sep 27, 2024
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc September 27, 2024 19:43 Inactive
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Sep 27, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Sep 27, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Sep 27, 2024
@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Sep 27, 2024
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Sep 27, 2024

Mathlib CI status (docs):

  • ✅ Mathlib branch lean-pr-testing-5500 has successfully built against this PR. (2024-09-27 20:50:29) View Log
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase e3811fd838e0b38edcfad0d52652894fb0e8a017 --onto 5e8718dff9d7906e1d4ca7020256dae7c05e49c2. (2024-10-02 04:04:49)

kmill and others added 3 commits October 2, 2024 12:23
makes git conflict notation act as a comment

needs stage0 update to get option to control incoming/current
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc October 2, 2024 04:06 Inactive
def parseStartDiff (errorMsg : String) : ParserFn :=
let p := satisfyFn (· == '<') errorMsg
andthenFn (checkColZero errorMsg)
(andthenFn p (andthenFn p (andthenFn p (andthenFn p (andthenFn p (andthenFn p (andthenFn p
Copy link

@adomani adomani Oct 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think of starting the diff with 6, rather than 7, <?

This means that you can remove the first <, exclude all editor diff-related noise, and view a "clean" file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builds-mathlib CI has verified that Mathlib builds against this PR changes-stage0 Contains stage0 changes, merge manually using rebase toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants