-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: nix: avoid adding search path symlinks to the nix store #2568
Conversation
Nice, any benchmarks yet? E.g. |
Before:
after
I wonder if it is even significant, I didn’t expect a regression, it has to create the same symlink trees as before, just during the per-module build rather than as a separate nix derivation. So that’s strange. Maybe invoking (Of course, the goal isn’t to make it faster per se, it’s to not have these symlink trees in |
Still no good idea why it’s slower, but I can report that the code works building all of mathlib (as part of the loogle deploy) |
Could be. Try measuring your script vs the corresponding |
b0b1051
to
195f597
Compare
Any idea why CI doesn’t run? |
Not sure. You might need to push again after the base change. |
195f597
to
bd4bd1d
Compare
|
No longer using this for loogle, so closing. Hopefully we will have a good lake-based nix setup eventually. |
This fixes #2508.
(Includes release branch commits for easier testing, will fix that
before undrafting)