Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make frontend normalize line endings to LF #3903
feat: make frontend normalize line endings to LF #3903
Changes from all commits
469bf38
b1464d1
147cac0
62adf98
a8dcff4
4d69191
87e6802
d74e1fb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to move
crlfToLf
totoFileMap
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
replaceLspRange
case made me decide not to incorporatecrlfToLf
intotoFileMap
. We only want to normalize the line endings of the new text, and it's worth making it explicit where we're normalizing.There's still something unsatisfactory however, which is that if somehow a
\r\n
is split and re-merged by edit operations, then we can get into a situation where there's an unnormalized\r\n
. I'm not sure if this is an issue that could crop up in practice.If we're not happy with leaving it in the current form, here are some solutions that came to mind:
\r
. It's not clear how to get this information back to the user in a nice way.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current state seems fine. I'm more worried about accidentally forgetting
crlfToLf
somewhere in the future, but I agree that this is not that important and explicitly seeing the normalization in the code is helpful, too.This file was deleted.