Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use text-variant of ✝︎ #5174

Closed
wants to merge 6 commits into from

Conversation

joneugster
Copy link
Contributor

@joneugster joneugster commented Aug 26, 2024

Second part of #5015, using emoji variant of unicode symbols for ✝︎.


(Partially) closes #5015

@joneugster
Copy link
Contributor Author

joneugster commented Aug 26, 2024

Note: This appends the text-variant selector \u{FE0E} to all ✝︎ \u{271D}\u{FE0E}.

Need to wait for nightly-with-mathlib to include #5173 (i.e. should be 29/08/2024)

Implications:

src/Init/Meta.lean Outdated Show resolved Hide resolved
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Aug 26, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase c6feffa2bdabc0fbd75e3f8c2f9f681fbb7b41f5 --onto 9305049f1ef7309842806c2a994a2020bb32a71f. (2024-08-26 17:02:22)

src/Init/Meta.lean Outdated Show resolved Hide resolved
Co-authored-by: Joachim Breitner <mail@joachim-breitner.de>
@nomeata nomeata added the awaiting-author Waiting for PR author to address issues label Aug 30, 2024
@nomeata
Copy link
Contributor

nomeata commented Aug 30, 2024

(Just labeling awaiting-author as per TODO list in first comment.)

@leanprover-bot leanprover-bot added the P-medium We may work on this issue if we find the time label Aug 30, 2024
@joneugster
Copy link
Contributor Author

I am not 100% confident, that this will not cause problems anywhere, and I don't strictly need this change. (having emojis marked as emojis means I can load the emoji font behind the non-emoji one and everything renders fine).

So I'm going to close this PR

@joneugster joneugster closed this Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-author Waiting for PR author to address issues P-medium We may work on this issue if we find the time toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC: Use emoji variant selector for unicode characters
4 participants